Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source level deprecation warning disabling to certain tests/utils #2645

Merged
merged 1 commit into from
May 13, 2021

Conversation

senhuang42
Copy link
Contributor

As title. This adds the macro to fuzzer, zstreamtest, fullbench, and Pzstd.

Also adds thread_dep target to fuzzer in meson build, and -Wno-deprecated-declarations to the pzstd target in meson. For some reason, including the deprecate macro isn't sufficient in Pzstd.h

I think this is all of them.

@Cyan4973
Copy link
Contributor

For some reason, including the deprecate macro isn't sufficient in Pzstd.h

That might be because zstd.h is included from Options.h too ?

@senhuang42
Copy link
Contributor Author

I have verified that this now builds locally. Still, there is the remaining question of what to do with all the warnings -Wdocumentation -Wcomment.

@senhuang42 senhuang42 merged commit 40def70 into facebook:dev May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants