-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelined Implementation of ZSTD_fast (~+5% Speed) #2749
Merged
Merged
Commits on Sep 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ab8aa49 - Browse repository at this point
Copy the full SHA ab8aa49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80bc12b - Browse repository at this point
Copy the full SHA 80bc12bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc768bc - Browse repository at this point
Copy the full SHA bc768bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 387840a - Browse repository at this point
Copy the full SHA 387840aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b092dd7 - Browse repository at this point
Copy the full SHA b092dd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35932ab - Browse repository at this point
Copy the full SHA 35932abView commit details -
Give Up on Searching End of Block
Amusingly, it seems to be a non-trivial performance hit to add in final searches or even hash table insertions during cleanup. So let's not. It seems to not make any meaningful difference in compression ratio.
Configuration menu - View commit details
-
Copy full SHA for 7c24c3e - Browse repository at this point
Copy the full SHA 7c24c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8706bc1 - Browse repository at this point
Copy the full SHA 8706bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 991d660 - Browse repository at this point
Copy the full SHA 991d660View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a100f - Browse repository at this point
Copy the full SHA 57a100fView commit details -
Unroll Loop Core; Reduce Frequency of Repcode Check & Step Calc (+>1%…
… Speed) Unrolling the loop to handle 2 positions in each iteration allows us to reduce the frequency of some operations that don't need to happen at every position. One such operation is the step calculation, which is a very rough heuristic anyways. It's fine if we do this a position later. The other operation is the repcode check. But since the repcode check already tries expanding back one position, we're really not missing much of importance by only trying it every other position. This commit also slightly reorders some operations.
Configuration menu - View commit details
-
Copy full SHA for 24fcccd - Browse repository at this point
Copy the full SHA 24fcccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64054de - Browse repository at this point
Copy the full SHA 64054deView commit details -
This removes the old `ZSTD_compressBlock_fast_generic()` and renames the new `ZSTD_compressBlock_fast_generic_pipelined()` to replace it. This is functionally a no-op.
Configuration menu - View commit details
-
Copy full SHA for 15e67bf - Browse repository at this point
Copy the full SHA 15e67bfView commit details -
It's a bit strange, because this is hitting the dictionary special case where the dictionary is contiguous with the input and still runs in the single- segment path. We should probably change that to hit the `extDict` path instead?
Configuration menu - View commit details
-
Copy full SHA for 98d3df3 - Browse repository at this point
Copy the full SHA 98d3df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6fd776 - Browse repository at this point
Copy the full SHA d6fd776View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0977e4 - Browse repository at this point
Copy the full SHA b0977e4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.