Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: Append -z cet-report=error to LDFLAGS #2994

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

hjl-tools
Copy link
Contributor

Append -z cet-report=error to LDFLAGS if -fcf-protection is enabled by
default in compiler to catch the missing Intel CET marker:

compiling multi-threaded dynamic library 1.5.1
/usr/local/bin/ld: obj/conf_f408b4c825de923ffc88f7f21b6884b1/dynamic/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status
...
LINK obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/zstd
/usr/local/bin/ld: obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status

@felixhandte
Copy link
Contributor

Great! Thanks for demonstrating this will catch missing CET support on an object.

However, we want commits to always build and pass tests (to make our lives easier if we have to bisect a problem). So after we merge #2992, it would be great if you could rebase this on top of that, so this will pass.

I'll accept and merge it then.

@hjl-tools
Copy link
Contributor Author

Great! Thanks for demonstrating this will catch missing CET support on an object.

However, we want commits to always build and pass tests (to make our lives easier if we have to bisect a problem). So after we merge #2992, it would be great if you could rebase this on top of that, so this will pass.

I'll accept and merge it then.

Will do. Thanks.

@felixhandte
Copy link
Contributor

@hjl-tools, please rebase this and then I will merge it.

Append -z cet-report=error to LDFLAGS if -fcf-protection is enabled by
default in compiler to catch the missing Intel CET marker:

compiling multi-threaded dynamic library 1.5.1
/usr/local/bin/ld: obj/conf_f408b4c825de923ffc88f7f21b6884b1/dynamic/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status
...
LINK obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/zstd
/usr/local/bin/ld: obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status
@hjl-tools
Copy link
Contributor Author

@hjl-tools, please rebase this and then I will merge it.

Done.

@felixhandte felixhandte merged commit c7e8315 into facebook:dev Jan 20, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants