Intial commit to address 3090. Added support to decompress empty block. #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the fix manually as well as running 'make test' and 'make check' the newly added test passes correctly. |
Addressed review comments for the case of 'set_basic'
terrelln
requested changes
May 4, 2022
Co-authored-by: Nick Terrell <nickrterrell@gmail.com>
Co-authored-by: Nick Terrell <nickrterrell@gmail.com>
terrelln
approved these changes
Jul 14, 2022
|
Thanks for the PR @udayanbapat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @terrelln, added a fix to address issue 3090 (#3090) to decompress minimum length 0 size block. As part of change MIN_CBLOCK_SIZE was changed from 3 to 2. However, since this macro was also used on the compression side, the logic was corrected by compensating with additional one. For clarity purposes, I have put a TODO comment and kept the logic as ..+1+1" instead of just "...+2".