Fix for MSVC C4267 warning on ARM64 (which becomes error C2220 with /WX) #3320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only seen this on the ARM64 toolchain under the new ARM64 version of VS 2022 (running on a shiny new Windows Dev Kit 2023), and didn't see it cross-compiling for ARM64 from x64:
The change is minimal:
i
can't be asize_t
because it needs to be signed, but changeingchunkSize
toint
is fine (it's only ever going to be 32 or 64 (or possibly somewhere between 16 to 128 on the more exotic systems).(I can't verify the warning on x64 to ARM64 until next week but it's such a minor unintrusive change with known values)