Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Meson-Windows CI test by pulling a more recent version msvc-dev-cmd #3374

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

yoniko
Copy link
Contributor

@yoniko yoniko commented Dec 17, 2022

Recently merge meson-windows CI test fails on a dependency issue.
Updating pinned hash to latest version remedies this issue.

@yoniko
Copy link
Contributor Author

yoniko commented Dec 17, 2022

@eli-schwartz looks like I was overly eager to merge your PR when in fact it was broken, this should fix the issue, please take a look.

@yoniko yoniko merged commit fba704f into facebook:dev Dec 17, 2022
@eli-schwartz
Copy link
Contributor

That's entirely possible, as I didn't even test the hash update (I did test the @v1 version). I didn't have any time yesterday to do more than push the update. Turns out I think I copied the hash from the head of the wrong branch though.

@yoniko yoniko deleted the fix-meson-ci-dependancy branch December 18, 2022 02:03
@yoniko
Copy link
Contributor Author

yoniko commented Dec 18, 2022

That's fine and thank you for contributing.
I was under the impression that the test failed due to a sporadic issue and decided to merge it, only later I realized it broke CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants