Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to build the contrib directory in Windows CI #3375

Closed
wants to merge 2 commits into from

Conversation

eli-schwartz
Copy link
Contributor

This is just going to fail. PR submitted as a demonstration. The logs look like this:

[82/90] Compiling C++ object contrib/pzstd/pzstd.exe.p/.._.._.._.._contrib_pzstd_Pzstd.cpp.obj
FAILED: contrib/pzstd/pzstd.exe.p/.._.._.._.._contrib_pzstd_Pzstd.cpp.obj 
"cl" "-Icontrib\pzstd\pzstd.exe.p" "-Icontrib\pzstd" "-I..\build\meson\contrib\pzstd" "-I..\programs" "-I..\contrib\pzstd" "-I..\lib" "-I..\lib\common" "-I..\lib\compress" "-I..\lib\decompress" "-I..\lib\dictBuilder" "-I..\lib\legacy" "-DNDEBUG" "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W4" "/EHsc" "/std:c++14" "/permissive-" "/O2" "/Gw" "/D_UNICODE" "/DUNICODE" "/MP" "/Fdcontrib\pzstd\pzstd.exe.p\.._.._.._.._contrib_pzstd_Pzstd.cpp.pdb" /Focontrib/pzstd/pzstd.exe.p/.._.._.._.._contrib_pzstd_Pzstd.cpp.obj "/c" ../contrib/pzstd/Pzstd.cpp
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C2589: '(': illegal token on right side of '::'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(126): note: see reference to class template instantiation 'pzstd::Range<Iter>' being compiled
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C3878: syntax error: unexpected token '(' following 'expression'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): note: error recovery skipped: '( ( identifier'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C2760: syntax error: ')' was unexpected here; expected ';'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C3878: syntax error: unexpected token ')' following 'jump_statement'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): note: error recovery skipped: ') <'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C3878: syntax error: unexpected token ')' following 'expression_statement'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): note: error recovery skipped: ') ?'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C2760: syntax error: ':' was unexpected here; expected ';'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): error C3878: syntax error: unexpected token ':' following 'expression_statement'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): note: error recovery skipped: ':'
D:\a\zstd\zstd\contrib\pzstd\utils/Range.h(124): note: error recovery skipped: ') )'
D:\a\zstd\zstd\contrib\pzstd\utils/FileSystem.h(85): warning C4245: 'return': conversion from 'int' to 'uintmax_t', signed/unsigned mismatch
D:\a\zstd\zstd\contrib\pzstd\utils/FileSystem.h(89): warning C4245: 'return': conversion from 'int' to 'uintmax_t', signed/unsigned mismatch
../contrib/pzstd/Pzstd.cpp(366): error C2589: '(': illegal token on right side of '::'
../contrib/pzstd/Pzstd.cpp(366): error C2062: type 'unknown-type' unexpected
../contrib/pzstd/Pzstd.cpp(366): error C2059: syntax error: ')'
../contrib/pzstd/Pzstd.cpp(367): error C3536: 'bytesRead': cannot be used before it is initialized
../contrib/pzstd/Pzstd.cpp(590): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data
[83/90] Compiling C object programs/zstd.exe.p/.._.._.._programs_timefn.c.obj
[84/90] Compiling C++ object contrib/gen_html/gen_html.exe.p/.._.._.._.._contrib_gen_html_gen_html.cpp.obj
ninja: build stopped: subcommand failed.

@terrelln
Copy link
Contributor

Thanks for the PR! These all look like easy fixes. I can stack a PR on top of this with the fixes and merge that.

terrelln added a commit to terrelln/zstd that referenced this pull request Dec 19, 2022
* `#include <algorithm>`
* Fix conversion warnings
* Assert that windowLog <= 23, which is currently always the case.
  This could be loosened, but we aren't looking to add new functionality.

Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
terrelln added a commit to terrelln/zstd that referenced this pull request Dec 19, 2022
* Add `Portability.h` to fix min/max issues.
* Fix conversion warnings
* Assert that windowLog <= 23, which is currently always the case.
  This could be loosened, but we aren't looking to add new functionality.

Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
@eli-schwartz
Copy link
Contributor Author

Nice, looks good. :)

terrelln added a commit to terrelln/zstd that referenced this pull request Dec 19, 2022
* Add `Portability.h` to fix min/max issues.
* Fix conversion warnings
* Assert that windowLog <= 23, which is currently always the case.
  This could be loosened, but we aren't looking to add new functionality.

Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
terrelln added a commit that referenced this pull request Dec 19, 2022
* Add `Portability.h` to fix min/max issues.
* Fix conversion warnings
* Assert that windowLog <= 23, which is currently always the case.
  This could be loosened, but we aren't looking to add new functionality.

Fixes on top of PR #3375 by @eli-schwartz, which added Windows CI for contrib & programs.
@terrelln
Copy link
Contributor

Merged as part of #3380.

@terrelln terrelln closed this Dec 19, 2022
@eli-schwartz eli-schwartz deleted the meson-ci-contrib branch December 19, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants