Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes AsyncIO performance regression for small files #3474

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

yoniko
Copy link
Contributor

@yoniko yoniko commented Feb 2, 2023

  • Do not use threaded AsyncIO when handling small files.
  • Some typo / doc fixes.
  • Benchmark:
binary				corpus	real_time	user_time	sys_time
zstd-1.5.2		silesia	0.620000	0.462000	0.150000
zstd-1.5.4-no-asyncio	silesia	0.622000	0.464000	0.148000
zstd-1.5.4-asyncio	silesia	0.520000	0.496000	0.158000
zstd-1.5.2		enwik8	0.342000	0.274000	0.060000
zstd-1.5.4-no-asyncio	enwik8	0.342000	0.272000	0.066000
zstd-1.5.4-asyncio	enwik8	0.290000	0.270000	0.086000
zstd-1.5.2		github	1.528000	0.254000	1.260000
zstd-1.5.4-no-asyncio	github	1.820000	0.258000	1.520000
zstd-1.5.4-asyncio	github	1.812000	0.270000	1.528000

- Do not use threaded AsyncIO when handling small files.
- Some typo / doc fixes
@yoniko yoniko merged commit 79bdb8c into facebook:dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants