-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zstd-dll build missing dependencies #3496
Conversation
lib/common/zstd_internal.h
Outdated
@@ -24,6 +24,8 @@ | |||
#include "mem.h" | |||
#include "debug.h" /* assert, DEBUGLOG, RAWLOG, g_debuglevel */ | |||
#include "error_private.h" | |||
#define ZSTD_DEPS_NEED_MALLOC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cyan4973 - Is there any issue with adding this to zstd_internal.h
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, zstd_internal.h
is used everywhere within libzstd
, so this change can impact a lot of places.
I'm not sure if I can understand all the implications.
971fb78
to
45f9c60
Compare
This PR manages to get To achieve that goal, this PR moves Now, I'm not exactly pleased about this dependency story.
Bundling more definitions within All in all, it seems this is an acceptable trade off. Longer term, I'm not pleased to see But that's a topic for a different effort, and since this PR is focused on |
- Adds pool.o and threading.o dependency to the zstd-dll target - Moves custom allocation functions into header to avoid needing to add dependency on common.o - Adds test target for zstd-dll - Adds github workflow for test zstd-dll
acb7257
to
2b44b8c
Compare
2b44b8c
to
65d628d
Compare
@Cyan4973 - all tests pass. Please see most recent changes, if it looks good to you we can merge. |
Fixes zstd-dll build (#3492 ):