-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable linker flag detection on MSVC/ClangCL. #3569
Conversation
This fixes compilation with clang-cl on Windows. There is a bug in cmake so that check_linker_flag() doesn't give the correct result when using link.exe/lld-link.exe. Details in CMake's gitlab: https://gitlab.kitware.com/cmake/cmake/-/issues/22023 Fixes facebook#3522
The fix looks fine, I suspected we used to have a Windows clang-cl test on Appveyor, |
When you say test - do you mean a build bot in this case that would build zstd with clang-cl? I am not very familiar with the github actions workers and configurations, maybe someone else could help with that? |
I'll look into it |
If I understand correctly, this should trigger the issue notified in #3569.
If I understand correctly, this should trigger the issue notified in #3569.
I added a Now, I wonder if the exact way it fails is the expected one, as I don't recognise the gitlab issue :
If yes, then it means that merging this PR, then rebasing #3579 on top of it, should fix the problem. |
If I understand correctly, this should trigger the issue notified in #3569.
Great! Thanks for the CI build, that hopefully means that our configuration will continue to work in the future! |
This fixes compilation with clang-cl on Windows. There
is a bug in cmake so that check_linker_flag() doesn't give
the correct result when using link.exe/lld-link.exe.
Details in CMake's gitlab: https://gitlab.kitware.com/cmake/cmake/-/issues/22023
Fixes #3522