Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

[ASImageNode] An ASImageNode debug feature showing pixel scaling amount #1336

Merged

Conversation

hannahmbanana
Copy link
Contributor

  • shows a red text label overlay on bottom right hand corner of ASImageNodes with pixel scaling factor
  • import AsyncDisplayKit+Debug.h and enable using [ASImageNode setEnableImageDebugOverlay]

- shows a red text label overlay on bottom right hand corner of ASImageNodes with pixel scaling factor
- import AsyncDisplayKit+Debug.h and enable using [ASImageNode setEnableImageDebugOverlay]
- shows a red text label overlay on bottom right hand corner of ASImageNodes with pixel scaling factor
- import AsyncDisplayKit+Debug.h and enable using [ASImageNode setEnableImageDebugOverlay]
- shows a red text label overlay on bottom right hand corner of ASImageNodes with pixel scaling factor
- import AsyncDisplayKit+Debug.h and enable using [ASImageNode setEnableImageDebugOverlay]
- shows a red text label overlay on bottom right hand corner of ASImageNodes with pixel scaling factor
- import AsyncDisplayKit+Debug.h and enable using [ASImageNode setEnableImageDebugOverlay]
@appleguy appleguy added this to the 1.9.8 milestone Mar 9, 2016
appleguy added a commit that referenced this pull request Mar 9, 2016
[ASImageNode] An ASImageNode debug feature showing pixel scaling amount
@appleguy appleguy merged commit 9759ed0 into facebookarchive:master Mar 9, 2016
@appleguy
Copy link
Contributor

appleguy commented Mar 9, 2016

@hannahmbanana Thanks a lot for this! It proved tremendously useful for finding oversized images in Pinterest a couple weeks ago when you sent me a hacked-up version. It's great to see it cleaned up and nicely integrated for everyone to use, along with supporting a runtime switch so it could be enabled with a developer menu.

@hannahmbanana
Copy link
Contributor Author

Documentation for this debug feature in Issue #1435

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants