This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASRangeController] Minimize number of registrations to node display notifications #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nguyenhuy
force-pushed
the
range_controller
branch
from
fc7853a
to
405dfd1
Compare
nguyenhuy
force-pushed
the
range_controller
branch
from
405dfd1
to
312de1a
Compare
|
@nguyenhuy thanks!! |
|
@nguyenhuy LGTM Other thinking around that is, any opinion about looking into finding a way to not align on |
|
Without interfering with Michael's question I'm going to merge this so that it's in the bag. |
|
@Adlai-Holler Thanks! @maicki: Will keep thinking about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ASRangeControllerregisters to notification center every time a range update is performed, regardless of the number of nodes that need to schedule for a recursive display in response to the update.Instead, if this number is taken into account and range controller doesn't observe further notifications if it is zero, we can minimize the number of range updates executed and may fix #1460 (verification needed though).