This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ASViewController] Support optional node #2810
Closed
nguyenhuy
wants to merge
3
commits into
facebookarchive:master
from
nguyenhuy:2760_ASViewController_nullable_node
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // | ||
| // PhotoFeedBaseController.h | ||
| // Sample | ||
| // | ||
| // Created by Huy Nguyen on 20/12/16. | ||
| // | ||
| // Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| // This source code is licensed under the BSD-style license found in the | ||
| // LICENSE file in the root directory of this source tree. An additional grant | ||
| // of patent rights can be found in the PATENTS file in the same directory. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
| // FACEBOOK BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN | ||
| // ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN | ||
| // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // | ||
|
|
||
| #import <AsyncDisplayKit/AsyncDisplayKit.h> | ||
| #import "AppDelegate.h" | ||
|
|
||
| @class PhotoFeedModel; | ||
|
|
||
| @interface PhotoFeedBaseController : ASViewController <PhotoFeedControllerProtocol> | ||
|
|
||
| @property (nonatomic, strong, readonly) PhotoFeedModel *photoFeed; | ||
| @property (nonatomic, strong, readonly) UITableView *tableView; | ||
|
|
||
| - (void)refreshFeed; | ||
| - (void)insertNewRows:(NSArray *)newPhotos; | ||
|
|
||
| #pragma mark - Subclasses must override these methods | ||
|
|
||
| - (void)loadPage; | ||
| - (void)requestCommentsForPhotos:(NSArray *)newPhotos; | ||
|
|
||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| // | ||
| // PhotoFeedBaseController.m | ||
| // Sample | ||
| // | ||
| // Created by Huy Nguyen on 20/12/16. | ||
| // Copyright © 2016 Facebook. All rights reserved. | ||
| // | ||
| // Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| // This source code is licensed under the BSD-style license found in the | ||
| // LICENSE file in the root directory of this source tree. An additional grant | ||
| // of patent rights can be found in the PATENTS file in the same directory. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
| // FACEBOOK BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN | ||
| // ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN | ||
| // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // | ||
|
|
||
| #import "PhotoFeedBaseController.h" | ||
| #import "PhotoFeedModel.h" | ||
|
|
||
| @implementation PhotoFeedBaseController | ||
| { | ||
| UIActivityIndicatorView *_activityIndicatorView; | ||
| } | ||
|
|
||
| // -loadView is guaranteed to be called on the main thread and is the appropriate place to | ||
| // set up an UIKit objects you may be using. | ||
| - (void)loadView | ||
| { | ||
| [super loadView]; | ||
|
|
||
| _activityIndicatorView = [[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]; | ||
|
|
||
| _photoFeed = [[PhotoFeedModel alloc] initWithPhotoFeedModelType:PhotoFeedModelTypePopular imageSize:[self imageSizeForScreenWidth]]; | ||
| [self refreshFeed]; | ||
|
|
||
| CGSize boundSize = self.view.bounds.size; | ||
| [_activityIndicatorView sizeToFit]; | ||
| CGRect refreshRect = _activityIndicatorView.frame; | ||
| refreshRect.origin = CGPointMake((boundSize.width - _activityIndicatorView.frame.size.width) / 2.0, | ||
| (boundSize.height - _activityIndicatorView.frame.size.height) / 2.0); | ||
| _activityIndicatorView.frame = refreshRect; | ||
| [self.view addSubview:_activityIndicatorView]; | ||
|
|
||
| self.tableView.allowsSelection = NO; | ||
| self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone; | ||
|
|
||
| self.view.backgroundColor = [UIColor whiteColor]; | ||
| } | ||
|
|
||
| - (void)refreshFeed | ||
| { | ||
| [_activityIndicatorView startAnimating]; | ||
| // small first batch | ||
| [_photoFeed refreshFeedWithCompletionBlock:^(NSArray *newPhotos){ | ||
|
|
||
| [_activityIndicatorView stopAnimating]; | ||
|
|
||
| [self insertNewRows:newPhotos]; | ||
| [self requestCommentsForPhotos:newPhotos]; | ||
|
|
||
| // immediately start second larger fetch | ||
| [self loadPage]; | ||
|
|
||
| } numResultsToReturn:4]; | ||
| } | ||
|
|
||
| - (void)insertNewRows:(NSArray *)newPhotos | ||
| { | ||
| NSInteger section = 0; | ||
| NSMutableArray *indexPaths = [NSMutableArray array]; | ||
|
|
||
| NSInteger newTotalNumberOfPhotos = [_photoFeed numberOfItemsInFeed]; | ||
| for (NSInteger row = newTotalNumberOfPhotos - newPhotos.count; row < newTotalNumberOfPhotos; row++) { | ||
| NSIndexPath *path = [NSIndexPath indexPathForRow:row inSection:section]; | ||
| [indexPaths addObject:path]; | ||
| } | ||
| [self.tableView insertRowsAtIndexPaths:indexPaths withRowAnimation:UITableViewRowAnimationNone]; | ||
| } | ||
|
|
||
| - (UIStatusBarStyle)preferredStatusBarStyle | ||
| { | ||
| return UIStatusBarStyleLightContent; | ||
| } | ||
|
|
||
| - (CGSize)imageSizeForScreenWidth | ||
| { | ||
| CGRect screenRect = [[UIScreen mainScreen] bounds]; | ||
| CGFloat screenScale = [[UIScreen mainScreen] scale]; | ||
| return CGSizeMake(screenRect.size.width * screenScale, screenRect.size.width * screenScale); | ||
| } | ||
|
|
||
| #pragma mark - PhotoFeedViewControllerProtocol | ||
|
|
||
| - (void)resetAllData | ||
| { | ||
| [_photoFeed clearFeed]; | ||
| [self.tableView reloadData]; | ||
| [self refreshFeed]; | ||
| } | ||
|
|
||
| #pragma mark - Subclassing | ||
|
|
||
| - (UITableView *)tableView | ||
| { | ||
| NSAssert(NO, @"Subclasses must override this method"); | ||
| return nil; | ||
| } | ||
|
|
||
| - (void)loadPage | ||
| { | ||
| NSAssert(NO, @"Subclasses must override this method"); | ||
| } | ||
|
|
||
| - (void)requestCommentsForPhotos:(NSArray *)newPhotos | ||
| { | ||
| NSAssert(NO, @"Subclasses must override this method"); | ||
| } | ||
|
|
||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use simply
[[ASDisplayNode alloc] init]here because using a view block results in a wrapper node, which has limited capacity compared to a node using_ASDisplayView.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks. Fixing.