Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

[Layout Transition] Reverting back _finishOrCancelTransition that was mistakingly moved in a recent PR #2820

Merged
merged 1 commit into from
Dec 21, 2016
Merged

[Layout Transition] Reverting back _finishOrCancelTransition that was mistakingly moved in a recent PR #2820

merged 1 commit into from
Dec 21, 2016

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Dec 21, 2016

Resolves: #2816

@maicki maicki requested a review from Adlai-Holler December 21, 2016 18:36
@maicki
Copy link
Contributor Author

maicki commented Dec 21, 2016

cc @garrettmoon @Adlai-Holler

garrettmoon
garrettmoon approved these changes Dec 21, 2016
View reviewed changes
Copy link
Contributor

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hannahmbanana hannahmbanana merged commit 7872cfb into facebookarchive:master Dec 21, 2016
hannahmbanana pushed a commit that referenced this pull request Dec 21, 2016
@maicki @garrettmoon
Reverting back _finishOrCancelTransition that was mistakingly moved i…
1201567 
…n a recent PR (#2820)
hannahmbanana pushed a commit that referenced this pull request Dec 28, 2016
@maicki @hannahmbanana
Reverting back _finishOrCancelTransition that was mistakingly moved i…
6fdbe5c 
…n a recent PR (#2820)
nguyenhuy added a commit to nguyenhuy/AsyncDisplayKit that referenced this pull request Jan 4, 2017
@nguyenhuy
Revert "Reverting back _finishOrCancelTransition that was mistakingly…
d491a35 
… moved in a recent PR (facebookarchive#2820)"

This reverts commit 7872cfb.
nguyenhuy added a commit to nguyenhuy/AsyncDisplayKit that referenced this pull request Jan 4, 2017
@nguyenhuy
Revert "Reverting back _finishOrCancelTransition that was mistakingly…
2186a2d 
… moved in a recent PR (facebookarchive#2820)"

This reverts commit 7872cfb.
hannahmbanana pushed a commit that referenced this pull request Jan 12, 2017
@garrettmoon
Revert "Reverting back _finishOrCancelTransition that was mistakingly…
0f00605 
… moved in a recent PR (#2820)"

This reverts commit 6fdbe5c.

Need to revert because it's too late in the release.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

@Adlai-Holler Adlai-Holler Awaiting requested review from Adlai-Holler

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maicki @garrettmoon @hannahmbanana @facebook-github-bot