Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Grammatical Mistakes #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Grammatical Mistakes #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[![Build Status](https://travis-ci.org/facebook/bistro.svg?branch=master)](https://travis-ci.org/facebook/bistro)

This README is a very abbreviated introduction to Bistro. Visit
http://facebook.github.io/bistro for a more structured introduction, and for the docs.
http://facebook.github.io/bistro for a more structured introduction, and the docs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a grammar fix, but a style preference. To me, having 2 "for" clauses is more clear. But if you feel passionate about this, do it your way.


Bistro is a toolkit for making distributed computation systems. It can
schedule and run distributed tasks, including data-parallel jobs. It
Expand Down Expand Up @@ -47,10 +47,10 @@ very similar steps on most modern Linux distributions.

If you run into dependency problems, look at `bistro/cmake/setup.cmake` for
a full list of Bistro's external dependencies (direct and indirect). We
gratefully accept patches that improve Bistro's builds, or add support for
gratefully accept patches that improve Bistro's builds or add support for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch, thanks.

various flavors of Linux and Mac OS.

The binaries will be in `bistro/cmake/{Debug,Release}`. Available build
The binaries will be in `bistro/cmake/{Debug, Release}`. Available build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change this. The {foo,bar} syntax has clear significance to anybody who uses a Bourne-style shell. Adding whitespace here changes the meaning. This is not a good fix, since the Release directory does not, in fact, have a leading space.

targets are explained here:
http://cmake.org/Wiki/CMake_Useful_Variables#Compilers_and_Tools
You can start Bistro's unit tests by running `ctest` in those directories.
Expand Down