[meta] fix clippy issues

facebookarchive · Aug 31, 2022 · b235cb6 · b235cb6
1 parent c489ddd
commit b235cb6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/guppy/src/graph/graph_impl.rs b/guppy/src/graph/graph_impl.rs
@@ -1481,9 +1481,8 @@ impl<'g> ExternalSource<'g> {
         } else if let Some(rest) = source.strip_prefix(Self::GIT_PLUS) {
             // A Git source.
             // Look for a trailing #, which indicates the resolved revision.
-            let mut split_rev = rest.rsplitn(2, '#');
-            let resolved = split_rev.next()?;
-            let rest = split_rev.next()?;
+            let (rest, resolved) = rest.rsplit_once('#')?;
+
             let (repository, req) = if let Some(idx) = rest.find(Self::BRANCH_EQ) {
                 (
                     &rest[..idx],

diff --git a/target-spec/src/errors.rs b/target-spec/src/errors.rs
@@ -77,7 +77,7 @@ impl error::Error for ExpressionParseError {
 /// An error returned while parsing a single target.
 ///
 /// This is caused by a triple not being understood by either `cfg-expr` or `target-lexicon`.
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct TripleParseError {
     triple_str: Cow<'static, str>,
     lexicon_err: cfg_expr::target_lexicon::ParseError,

diff --git a/tools/cargo-hakari/src/output.rs b/tools/cargo-hakari/src/output.rs
@@ -121,7 +121,7 @@ fn stderr_supports_color() -> bool {
     }
 }
 
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[must_use]
 pub enum Color {
     Auto,