Single key operation #77
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Awesome, thanks! ❤️ I have a few questions that I'll post inline. Also, it looks like you'll need to rebase before these changes can be merged. |
| @@ -670,7 +671,7 @@ def _ask_about_patch(patch, editor, default_no): | |||
| else: | |||
| print ('Accept change (y = yes [default], n = no, e = edit, ' + | |||
| 'A = yes to all, E = yes+edit)? '), | |||
| p = _prompt('yneEA', default=default_action) | |||
| p = _prompt('yneEAq', default=default_action) | |||
There was a problem hiding this comment.
Maybe I'm misunderstanding, but It seems like this and the sys.exit(0) call below could be split off into their own pull request. Splitting it out would make this easier to review/merge.
snickl
force-pushed
the
snickl
branch
2 times, most recently
from
88c5981
to
869f094
Compare
ghost
added
the
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
As per your comment above, let me try this on an OS X machine before merging. Give me a few days to get around to it -- thanks! |
Small patch I've been using for a while now under Linux to avoid having to press Enter all the time.
It probably only works for Unix-like systems so I don't expect it to be merged per se, but maybe someone will be inspired to make it cross-platform.