This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
this pull request fixed broken Tex example by removing outdated syntax that changed in #376. refer issue to #697
- Loading branch information
Showing
2 changed files
with
11 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1559e9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flarnie it is my understanding that this breaks as of 0.9.1
I don't believe contentState gets passed via the blockRendererFn, and according to your docs and my testing, ContentState.mergeEntityData is not a thing anymore.
Am I just confused?
1559e9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking at the TeX example, and this commit everything looks good: 36b0e71
1559e9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Casen - you are right that this change doesn't work with Draft version 0.9.1. The API on the master branch has changed compared to what is present in version 0.9.1. We have landed an API change as of #376 that changed the syntax. It has not been released yet, and we are working on updating the documentation and creating a guide for folks to migrate to the new API. Hopefully we will release the update soon and get things back in sync.
Thanks for your patience - please let me know if any questions remain.