Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Commit

Permalink
Add return type annotation to addEmojiInput
Browse files Browse the repository at this point in the history
Summary:
Flow does not infer generics, so generic functions should have annotated return
types. This will become an error in the next Flow version.

Note that this uncovered a bunch of errors, which I mostly fixed. I suppressed
a few that would require code changes.

Reviewed By: nmote

Differential Revision: D10419507

fbshipit-source-id: 84b8f33f3c8fe272b18e35e838a0ebf7bdbaa6ff
  • Loading branch information
samwgoldman authored and facebook-github-bot committed Oct 17, 2018
1 parent 7df9eb9 commit 280d242
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/component/base/DraftEditorProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export type DraftEditorProps = {
// styling and formatting when re-applying styles.
editorKey?: string,

// $FlowFixMe in practice people pass other renderable things here
placeholder?: string,

// Specify whether text alignment should be forced in a direction
Expand Down
2 changes: 1 addition & 1 deletion src/model/constants/DraftHandleValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
* A type that allows us to avoid returning boolean values
* to indicate whether an event was handled or not.
*/
export type DraftHandleValue = 'handled' | 'not-handled';
export type DraftHandleValue = 'handled' | 'not-handled' | boolean;

0 comments on commit 280d242

Please sign in to comment.