This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add weekly meeting notes from July 7th and 14th
Summary: Closes #1290 Differential Revision: D5432441 fbshipit-source-id: 1709a5ee540164f5859382adcec7c19d97e59b46
- Loading branch information
1 parent
cbf9761
commit ce7f8ca
Showing
2 changed files
with
61 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Draft.js Weekly 07/07/17 | ||
|
||
Agenda Items: | ||
|
||
* Goal: Review/close 30 PRs by end of the half. | ||
* Review 3 every Friday | ||
* Close or import at least 2 by Monday | ||
* If no problems are caused by following Friday, include in a minor release or patch. | ||
* Update on automated PR syncing between Github and Facebook | ||
* Almost finished setting this up | ||
* Onboarding new internal maintainers | ||
* New logging of internal use of Draft - it's widely used :) | ||
|
||
PRs to consider: | ||
|
||
* 1190 (https://github.com/facebook/draft-js/pull/1190) - selection.extend is called on selection without ranges | ||
* Commented with requirements to merge, following up in a week | ||
* “Selection code is the scariest part of this whole codebase, I think... This doesn't even surprise me that this bug exists.” - Isaac | ||
* Might close https://github.com/facebook/draft-js/pull/1203 in favor of #1190 but it's in IE11, so we are following up with our contacts at MS | ||
* (for next week) 1170 (https://github.com/facebook/draft-js/pull/1170) - updates syntax in docs, just need to get CI passing. Not sure why it failed. | ||
* (for next week) 927 (https://github.com/facebook/draft-js/pull/927) - don't merge sequential unstyled tags | ||
|
||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Draft.js Weekly 07/14/17 | ||
|
||
Agenda Items: | ||
|
||
* Intros for new folks | ||
* Update on automated PR syncing between Github and Facebook | ||
* Working as of today! | ||
* Bug fixes - fix typing into text node containing tab | ||
* Merged on Github as https://github.com/facebook/draft-js/commit/5863399a3a1bcbbe9b090249504a70496a7af7cc | ||
|
||
PRs to consider: | ||
|
||
* 1285 (https://github.com/facebook/draft-js/pull/1285) - 'Added support for the `compositionUpdate` event' | ||
* This is only for Android, but we don't want to browser sniff if we can help it | ||
* Also events vary by keyboard so we can't sniff for that | ||
* Concern: composition events are different in each browser/OS combination, and we want to avoid breaking them | ||
* At very least we would want to manually test across different browsers/OS, with IME and different languages | ||
* If it falls back to 'compositionUpdate' instead of falling back to 'beforeInput' that is a smaller change | ||
* Another complication; the 'beforeInput' event is “normalized” in React. | ||
* Another potential fix; change the 'beforeInput' in React to fire based on 'compositionUpdate'. | ||
* Might eventually pull this code from React into Draft | ||
* Would merge if: | ||
* we manually test across OS/browsers | ||
* fall back to 'compositionUpdate' | ||
* test internally on FB employees for a week or so | ||
* (for next week) 927 (https://github.com/facebook/draft-js/pull/927) - don't merge sequential unstyled tags | ||
* (for next week) 1170 (https://github.com/facebook/draft-js/pull/1170) - updates syntax in docs, just need to get CI passing. Not sure why it failed. | ||
* Will follow up soon | ||
* (from last week) | ||
* 1190 (https://github.com/facebook/draft-js/pull/1190) - selection.extend is called on selection without ranges | ||
* No response to comments last week | ||
* Pinged the PR and issue again to see if anyone is interested in debugging Chrome issue | ||
|
||
|
||
|
||
|