Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Commit

Permalink
Upgrades flow-bin to 0.91.0 and mutes fbjs joinClasses error � (#1989)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

Fixes a CI build error (#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0

**Test Plan**

```
yarn run flow
flow src
```

```
→ flow src
The flow server's version didn't match the client's, so it exited.
Going to launch a new one.

Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src
Spawned flow server (pid=87525)
Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log
Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log
No errors!
```
Pull Request resolved: #1989

Reviewed By: pakoito

Differential Revision: D13917267

Pulled By: pakoito

fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
  • Loading branch information
Claudio Procida authored and facebook-github-bot committed Feb 1, 2019
1 parent c022efb commit e8a281c
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion meta/bundle-size-stats/Draft.js.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion meta/bundle-size-stats/Draft.min.js.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"eslint-plugin-react": "^7.3.0",
"eslint-plugin-relay": "^0.0.8",
"fbjs-scripts": "^0.8.0",
"flow-bin": "^0.70.0",
"flow-bin": "^0.92.0",
"gulp": "^4.0.0",
"gulp-babel": "^6.1.2",
"gulp-browserify-thin": "^0.1.5",
Expand Down
3 changes: 2 additions & 1 deletion src/.flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ module.system.haste.paths.blacklist=.*/node_modules/invariant/.*
esproposal.class_static_fields=enable
suppress_type=$FlowIssue
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-8]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\).*\n
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
module.name_mapper='ReactDOM' -> 'react-dom'

[version]
^0.70.0
^0.92.0
1 change: 1 addition & 0 deletions src/component/contents/DraftEditorContents-core.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ class DraftEditorContents extends React.Component<Props> {
lastWrapperTemplate !== wrapperTemplate ||
currentDepth === null ||
depth > currentDepth;
// $FlowExpectedError joinClasses args in fbjs@1.0.0 are incorrect
className = joinClasses(
className,
getListItemClasses(blockType, depth, shouldResetCount, direction),
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2619,10 +2619,10 @@ flat-cache@^1.2.1:
graceful-fs "^4.1.2"
write "^0.2.1"

flow-bin@^0.70.0:
version "0.70.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.70.0.tgz#080ae83a997f2b4ddb3dc2649bf13336825292b5"
integrity sha1-CAroOpl/K03bPcJkm/EzNoJSkrU=
flow-bin@^0.92.0:
version "0.92.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.92.0.tgz#f5bf3e808b17b480e067ac673829ca715a168bea"
integrity sha512-3ErXSAXZZlLV5/QPlaUDCWlDUXop1SiH32ifXL3SEiBwsmGbudCLim+HFVZfkegrn1nB4TcNSkMWtW8SnMPyAQ==

flush-write-stream@^1.0.0:
version "1.0.2"
Expand Down

0 comments on commit e8a281c

Please sign in to comment.