This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Improve style by removing boolean param in getCharacterRemovalRange.js
#1116
Labels
Comments
jackyho112
added a commit
to jackyho112/draft-js
that referenced
this issue
Apr 17, 2017
* get rid of the two boolean flags added in facebookarchive#1108 * rearrange code in a procedural/imperative style to be more understandable this fixes facebookarchive#1116
|
@flarnie I've pushed a fix as per the requirements. It's been sitting there for a while. Can you take a look? Feedback would be appreciated. |
|
@flarnie Is this project is not maintained anymore? |
|
is anyone working on this issue ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A recent change added two boolean flag params to
getCharacterRemovalRange.js. Boolean params generally make code less readable and maintainable - this is not worth blocking a PR at this time, but it would be great to update this file and the callsites to call two methods instead of passing in different boolean params.The text was updated successfully, but these errors were encountered: