-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Cannot type Chinese in Edge #2082
Comments
When I change https://github.com/facebook/draft-js/blob/master/src/component/handlers/composition/DOMObserver.js#L120 from
to
This appears to be working correctly. Some preliminary testing seems to indicate that it also works on Android, and on browsers other than Edge, but I might be missing something. @fabiomcosta: I'd be very interested in hearing your thoughts on this. Do you think this fix is in the right direction? |
Hi @robbertbrak thank you so much for looking further and finding a fix!
Now removing "r" and going back to the previous like by pressing Backspace 2 times should create the proper draft-js EditorState. I'm just providing this as a test case so you can make sure no bugs are introduced in this case. By looking at your code, I don't there will be though, the fix looks pretty safe to me. Do you want to go ahead and create a PR? cc @claudiopro |
Summary: Fixes facebookarchive#2082. Pull Request resolved: facebookarchive#2088 Differential Revision: D18698264 Pulled By: mrkev fbshipit-source-id: f5f5d4e4a0ff66a9fef62976af8726660411a106
Summary: Fixes facebookarchive#2082. Pull Request resolved: facebookarchive#2088 Differential Revision: D18698264 Pulled By: mrkev fbshipit-source-id: f5f5d4e4a0ff66a9fef62976af8726660411a106
Summary: Fixes facebookarchive/draft-js#2082. Pull Request resolved: facebookarchive/draft-js#2088 Differential Revision: D18698264 Pulled By: mrkev fbshipit-source-id: f5f5d4e4a0ff66a9fef62976af8726660411a106
To reproduce:
nihao1
Result: the text disappears. See the below screencast:
Note that it does work correctly when the block already contains some text.
The text was updated successfully, but these errors were encountered: