Fix autocomplete behavior for Android chrome. #1013
Conversation
Based off facebookarchive#175, this commit fixes some issues with autocomplete behavior on Android Chrome.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
.gitignore
Outdated
| @@ -9,3 +9,4 @@ | |||
| /website/src/draft-js/lib/ | |||
| /website/src/draft-js/docs/ | |||
| npm-debug.log | |||
| .idea/ | |||
There was a problem hiding this comment.
Is it typical to add this to your global .gitignore?
There was a problem hiding this comment.
Oops, sorry, that's an artifact of IntelliJ editors, I added it so config files wouldn't be thrown in with the changes. I'll remove it...
|
@flarnie Ping? |
|
For anyone wondering, this doesn't seem to fix #1224 (I thought it might) Tested with this PR merged in https://www.npmjs.com/package/@mathieumg/draft-js |
|
Thanks for reopening this @AndrewSouthpaw and for verifying that it doesn't seem to fix #1224 @mathieumg. I'm working on setting up syncing between FB and Github today, and once that is done we will be unblocked to merge some PRs and test them internally at Facebook. Thanks to everyone for your patience. |
|
How comes this PR never got merged? Seems like it would be useful to have. |
This is essentially the same as #175, which was closed due to inactivity. A couple minor adjustments were made to the original PR in order to have it fit with the latest version of Draft.
This commit fixes some issues with autocomplete behavior on Android Chrome.
Problem 1: Keyboard loses focus
Refers to #907 and repro steps are listed there. This PR addresses the problem listed there, albeit in a different way.
Problem 2: Replacing a word with autocomplete is broken
Steps to repro: