This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Allow Option+Space to be handled on OSX Chrome #1254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinjeanne
force-pushed
the
capture-nbsp
branch
2 times, most recently
from
2fb952f
to
6cc4688
Compare
|
@colinjeanne - apologies for the delay in reviewing this. Regarding the bundle size files, I think you can ignore them & remove them from the commit. Could you do that and rebase on master? (side note: I saw your PM on Slack and am looking into the possibility of adding this to |
Currently pressing Option+Space in Chrome on OSX will cause a non breaking space to always be inserted into the editor. This behavior ignores any key bindings that the editor has set. This change moves the logic which adds the non breaking space to after the point that the key binding function has been run in order to give editors a chance to handle this behavior on their own.
colinjeanne
force-pushed
the
capture-nbsp
branch
from
6cc4688
to
da60a1c
Compare
|
Next steps are:
|
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Currently pressing Option+Space in Chrome on OSX will cause a nonbreaking space to always be inserted into the editor. This behavior ignores any key bindings that the editor has set. This change moves the logic which adds the non breaking space to after the point that the key binding function has been run in order to give editors a chance to handle this behavior on their own. **Test Plan** This has been tested manually since there are no current tests for the event handlers and no current framework for testing the handlers. We have been running [with this change in our fork of Draft](textioHQ@f4c3aeb) for about seven months without issue. Pull Request resolved: facebookarchive#1254 Differential Revision: D10241854 fbshipit-source-id: b8fe92a4f76bbb7543efdb3e5deca1dbdbc0960c
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Currently pressing Option+Space in Chrome on OSX will cause a nonbreaking space to always be inserted into the editor. This behavior ignores any key bindings that the editor has set. This change moves the logic which adds the non breaking space to after the point that the key binding function has been run in order to give editors a chance to handle this behavior on their own. **Test Plan** This has been tested manually since there are no current tests for the event handlers and no current framework for testing the handlers. We have been running [with this change in our fork of Draft](textioHQ/draft-js@f4c3aeb) for about seven months without issue. Pull Request resolved: facebookarchive/draft-js#1254 Differential Revision: D10241854 fbshipit-source-id: b8fe92a4f76bbb7543efdb3e5deca1dbdbc0960c
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Currently pressing Option+Space in Chrome on OSX will cause a nonbreaking space to always be inserted into the editor. This behavior ignores any key bindings that the editor has set. This change moves the logic which adds the non breaking space to after the point that the key binding function has been run in order to give editors a chance to handle this behavior on their own. **Test Plan** This has been tested manually since there are no current tests for the event handlers and no current framework for testing the handlers. We have been running [with this change in our fork of Draft](textioHQ/draft-js@f4c3aeb) for about seven months without issue. Pull Request resolved: facebookarchive/draft-js#1254 Differential Revision: D10241854 fbshipit-source-id: b8fe92a4f76bbb7543efdb3e5deca1dbdbc0960c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently pressing Option+Space in Chrome on OSX will cause a nonbreaking space to always be inserted into the editor. This behavior ignores any key bindings that the editor has set.
This change moves the logic which adds the non breaking space to after the point that the key binding function has been run in order to give editors a chance to handle this behavior on their own.
Test Plan
This has been tested manually since there are no current tests for the event handlers and no current framework for testing the handlers. We have been running with this change in our fork of Draft for about seven months without issue.