This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
WIP Fixup diff for enabling 'ship-it' and 'import-it' #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**WIP because:** Flow is not passing. We are on a later version of Flow internally, which required a new 'FlowFixMe' comment. When I update the Flow version in OS we get a new error about missing 'setImmediate' module. Need to figure this out before landing. **what is the change?:** Development on Draft.js is causing Github and our internal version to get out of sync. This pulls various changes from our internal version into the Github project, so that they will be basically the same. Some of the included changes; - Reorder requires via a codemod, maintained by an ESLint rule (D5117037) - Fix 'first character prevention' bug that is triggered by Fiber async rendering (D5161053) - Add 'z-index' to placeholder (D4769133) - Add possible fix for issue facebookarchive#1020 (D5261172) - Add 'flowfixme' comment (D5337485) For reference, this patch was generated by the commands listed in D5273910. **why make this change?:** We want to keep them in sync going forward, and will be enabling scripts to automate mirroring changes back and forth. **test plan:** `yarn install && yarn build && yarn test` and manually tested examples. fbshipit-source-id:2b886ea7d631aefb30b440c0cd7a0e43f165791b
|
Abandoned in favor of #1286 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because: Flow is not passing. We are on a later version of Flow
internally, which required a new 'FlowFixMe' comment. When I update the
Flow version in OS we get a new error about missing 'setImmediate'
module. Need to figure this out before landing.
what is the change?:
Development on Draft.js is causing Github and our internal version to
get out of sync.
This pulls various changes from our internal version into the Github
project, so that they will be basically the same.
Some of the included changes;
(D5117037)
rendering (D5161053)
For reference, this patch was generated by the commands listed in
D5273910.
why make this change?:
We want to keep them in sync going forward, and will be enabling scripts
to automate mirroring changes back and forth.
test plan:
yarn install && yarn build && yarn testand manually tested examples.issue:
related to #1244
fbshipit-source-id:2b886ea7d631aefb30b440c0cd7a0e43f165791b