Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Revert "rename-unsafe-lifecycles" #1705

Closed

Conversation

mitermayer
Copy link
Contributor

This reverts commit 8b3e8c9.

cc @bvaughn @flarnie

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable change to get the components working with React < 16.3 again. (Sorry about the break!)

cc @flarnie: For a longer term fix, we need to remove the unsafe lifecycles entirely.

@bvaughn
Copy link
Contributor

bvaughn commented Mar 22, 2018

cc @flarnie: Maybe we could do this for now by moving the componentWillUpdate code into render?

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitermayer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@flarnie
Copy link
Contributor

flarnie commented Mar 23, 2018

Once I'm back in the office next week planning to finish the roll-out of those GKs, then cWU can be removed.

@bvaughn
Copy link
Contributor

bvaughn commented Mar 23, 2018

Great ! 😁

alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
This reverts commit 8b3e8c95f197453c8806175a59403c607c4f498d.

cc bvaughn flarnie
Closes facebookarchive/draft-js#1705

Differential Revision: D7361922

fbshipit-source-id: c1d1acd884996c4ac1f50c13c0001815dc057088
aforismesen added a commit to aforismesen/draft-js that referenced this pull request Jul 12, 2024
Summary:
This reverts commit 0f7378a.

cc bvaughn flarnie
Closes facebookarchive/draft-js#1705

Differential Revision: D7361922

fbshipit-source-id: c1d1acd884996c4ac1f50c13c0001815dc057088
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants