This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update Advanced-Topics-Entities.md #1767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a line of code in the example to set the editor state after adding the entity. For a newcomer, it's not straightforward because it wasn't mentioned anywhere in the docs prior to arriving here. Of course, you'll figure it out once you check the example. But let's save newcomers a roundtrip
|
Good idea :-) I would prefer if the line used |
niveditc
approved these changes
Sep 8, 2018
niveditc
suggested changes
Sep 8, 2018
Change `set` to `push`
niveditc
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: Add a line of code in the example to set the editor state after adding the entity. For a newcomer, it's not straightforward because it wasn't mentioned anywhere in the docs prior to arriving here. Of course, you'll figure it out once you check the example. But let's save newcomers a roundtrip **Summary** Update the docs Pull Request resolved: facebookarchive#1767 Differential Revision: D9749305 fbshipit-source-id: 88af5ee30690fa41cc72280a6bad153a17324c33
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Add a line of code in the example to set the editor state after adding the entity. For a newcomer, it's not straightforward because it wasn't mentioned anywhere in the docs prior to arriving here. Of course, you'll figure it out once you check the example. But let's save newcomers a roundtrip **Summary** Update the docs Pull Request resolved: facebookarchive/draft-js#1767 Differential Revision: D9749305 fbshipit-source-id: 88af5ee30690fa41cc72280a6bad153a17324c33
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Add a line of code in the example to set the editor state after adding the entity. For a newcomer, it's not straightforward because it wasn't mentioned anywhere in the docs prior to arriving here. Of course, you'll figure it out once you check the example. But let's save newcomers a roundtrip **Summary** Update the docs Pull Request resolved: facebookarchive/draft-js#1767 Differential Revision: D9749305 fbshipit-source-id: 88af5ee30690fa41cc72280a6bad153a17324c33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a line of code in the example to set the editor state after adding the entity.
For a newcomer, it's not straightforward because it wasn't mentioned anywhere in the docs prior to arriving here. Of course, you'll figure it out once you check the example. But let's save newcomers a roundtrip
Summary
Update the docs