This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update Docusaurus to 1.3.3 #1797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
yangshun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: Docusaurus 1.3.0 brings about some [backwards-incompatible CSS changes](https://github.com/facebook/Docusaurus/blob/master/CHANGELOG.md#breaking-changes). So the team is helping the major users update 😄 The header font weights in Docusuaurs have been changed to bold, so I removed the custom styling that made it bold. Additionally, I made `<a>` have a different color because the primary color in Draft.js is black and users can't easily distinguish it from body text - bad for accessibility. cc JoelMarcey endiliey Ran the site locally and visited every page. <img width="1552" alt="screen shot 2018-06-24 at 8 38 28 pm" src="https://user-images.githubusercontent.com/1315101/41829262-96daa336-77ee-11e8-881a-629297843d34.png"> <img width="1552" alt="screen shot 2018-06-24 at 8 38 32 pm" src="https://user-images.githubusercontent.com/1315101/41829265-9adbee4a-77ee-11e8-89e7-0e95a9d58026.png"> Pull Request resolved: facebookarchive#1797 Reviewed By: flarnie Differential Revision: D9560933 Pulled By: flarnie fbshipit-source-id: 4e3938cda818f6d6623ab301b4d8612e80b2f973
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Docusaurus 1.3.0 brings about some [backwards-incompatible CSS changes](https://github.com/facebook/Docusaurus/blob/master/CHANGELOG.md#breaking-changes). So the team is helping the major users update 😄 The header font weights in Docusuaurs have been changed to bold, so I removed the custom styling that made it bold. Additionally, I made `<a>` have a different color because the primary color in Draft.js is black and users can't easily distinguish it from body text - bad for accessibility. cc JoelMarcey endiliey Ran the site locally and visited every page. <img width="1552" alt="screen shot 2018-06-24 at 8 38 28 pm" src="https://user-images.githubusercontent.com/1315101/41829262-96daa336-77ee-11e8-881a-629297843d34.png"> <img width="1552" alt="screen shot 2018-06-24 at 8 38 32 pm" src="https://user-images.githubusercontent.com/1315101/41829265-9adbee4a-77ee-11e8-89e7-0e95a9d58026.png"> Pull Request resolved: facebookarchive/draft-js#1797 Reviewed By: flarnie Differential Revision: D9560933 Pulled By: flarnie fbshipit-source-id: 4e3938cda818f6d6623ab301b4d8612e80b2f973
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Docusaurus 1.3.0 brings about some [backwards-incompatible CSS changes](https://github.com/facebook/Docusaurus/blob/master/CHANGELOG.md#breaking-changes). So the team is helping the major users update 😄 The header font weights in Docusuaurs have been changed to bold, so I removed the custom styling that made it bold. Additionally, I made `<a>` have a different color because the primary color in Draft.js is black and users can't easily distinguish it from body text - bad for accessibility. cc JoelMarcey endiliey Ran the site locally and visited every page. <img width="1552" alt="screen shot 2018-06-24 at 8 38 28 pm" src="https://user-images.githubusercontent.com/1315101/41829262-96daa336-77ee-11e8-881a-629297843d34.png"> <img width="1552" alt="screen shot 2018-06-24 at 8 38 32 pm" src="https://user-images.githubusercontent.com/1315101/41829265-9adbee4a-77ee-11e8-89e7-0e95a9d58026.png"> Pull Request resolved: facebookarchive/draft-js#1797 Reviewed By: flarnie Differential Revision: D9560933 Pulled By: flarnie fbshipit-source-id: 4e3938cda818f6d6623ab301b4d8612e80b2f973
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docusaurus 1.3.0 brings about some backwards-incompatible CSS changes. So the team is helping the major users update 😄
The header font weights in Docusuaurs have been changed to bold, so I removed the custom styling that made it bold. Additionally, I made
<a>have a different color because the primary color in Draft.js is black and users can't easily distinguish it from body text - bad for accessibility.cc @JoelMarcey @endiliey
Test plan
Ran the site locally and visited every page.