This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
WIP version of rich text utils that is compatible with tree nesting data structures #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2018
Summary: Splitting this PR into smaller pieces and updating them. This chunk just makes some improvements/fixes to the removeRangeFromContentState logic that handles nested blocks. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: #1828 Reviewed By: mitermayer Differential Revision: D9181963 Pulled By: mitermayer fbshipit-source-id: 98abba5ed76ed00207aafc59afe940dd2eeb3d00
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2018
Summary: Splitting up this PR and updating it as I do. This piece was an update to the Rich Text Editor example. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: #1828 Reviewed By: mitermayer Differential Revision: D9181983 Pulled By: mitermayer fbshipit-source-id: aa2b66cb87123f96c3cd9cde19eb0fa86ff47c51
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: We are splitting up and updating pieces of this PR by Mitermayer. This chunk forks the RichTextEditorUtil and puts them both under the same Flow interface, also adding a test. The forked NestedRichTextEditorUtil is a WIP version of this utility. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181952 Pulled By: mitermayer fbshipit-source-id: 75f08fdb228ae1b45f97ae29aeae2f3d5ea53650
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Splitting this PR into smaller pieces and updating them. This chunk just makes some improvements/fixes to the removeRangeFromContentState logic that handles nested blocks. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181963 Pulled By: mitermayer fbshipit-source-id: 98abba5ed76ed00207aafc59afe940dd2eeb3d00
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Splitting up this PR and updating it as I do. This piece was an update to the Rich Text Editor example. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181983 Pulled By: mitermayer fbshipit-source-id: aa2b66cb87123f96c3cd9cde19eb0fa86ff47c51
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: We are splitting up and updating pieces of this PR by Mitermayer. This chunk forks the RichTextEditorUtil and puts them both under the same Flow interface, also adding a test. The forked NestedRichTextEditorUtil is a WIP version of this utility. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181952 Pulled By: mitermayer fbshipit-source-id: 75f08fdb228ae1b45f97ae29aeae2f3d5ea53650
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Splitting this PR into smaller pieces and updating them. This chunk just makes some improvements/fixes to the removeRangeFromContentState logic that handles nested blocks. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181963 Pulled By: mitermayer fbshipit-source-id: 98abba5ed76ed00207aafc59afe940dd2eeb3d00
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Splitting up this PR and updating it as I do. This piece was an update to the Rich Text Editor example. This is directly taken from mitermayer 's fork, props to him Pull Request resolved: facebookarchive/draft-js#1828 Reviewed By: mitermayer Differential Revision: D9181983 Pulled By: mitermayer fbshipit-source-id: aa2b66cb87123f96c3cd9cde19eb0fa86ff47c51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental! Look away ✨🎩🐇
Also this is directly taken from @mitermayer 's fork, props to him