This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update prettier version to 1.13.6 #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Updating to 1.13.6 which is the version used internally in Facebook's codebase, so that there are no conflicts in how prettier dictates formatting. Right now, we're seeing an issue where 1.13.6 dictates different formatting for nested ternary operators & this broke the Travis CI in facebookarchive/draft-js@0cb80b7...fbc8a0c#diff-4e6b8232e09a07f699eebad1949b3ba3L118 Looks like the earlier breakage due to prettier version upgrade reported in facebookarchive#1562 is now not an issue with a much higher version :) **Test Plan** Before fix (breakage in Travis at https://travis-ci.org/facebook/draft-js/jobs/424170309): ``` $ eslint . /home/travis/build/facebook/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars /home/travis/build/facebook/draft-js/src/model/transaction/moveBlockInContentState.js 119:33 error Replace `⏎··········?·targetBlockIndex·-·1⏎·········` with `·?·targetBlockIndex·-·1` prettier/prettier ✖ 2 problems (1 error, 1 warning) 1 error, 0 warnings potentially fixable with the `--fix` option. ``` After fix: ``` > yarn run lint Using globally installed version of Yarn yarn run v1.5.1 $ eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ✨ Done in 8.50s. ``` (will be fixing the warning separately, that's been ongoing for a while). Pull Request resolved: facebookarchive#1854 Reviewed By: elboman Differential Revision: D9636114 Pulled By: elboman fbshipit-source-id: 037c692554976b4626e27d3ebc0ccf95922bfb38
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Updating to 1.13.6 which is the version used internally in Facebook's codebase, so that there are no conflicts in how prettier dictates formatting. Right now, we're seeing an issue where 1.13.6 dictates different formatting for nested ternary operators & this broke the Travis CI in facebookarchive/draft-js@0cb80b7...fbc8a0c#diff-4e6b8232e09a07f699eebad1949b3ba3L118 Looks like the earlier breakage due to prettier version upgrade reported in facebookarchive/draft-js#1562 is now not an issue with a much higher version :) **Test Plan** Before fix (breakage in Travis at https://travis-ci.org/facebook/draft-js/jobs/424170309): ``` $ eslint . /home/travis/build/facebook/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars /home/travis/build/facebook/draft-js/src/model/transaction/moveBlockInContentState.js 119:33 error Replace `⏎··········?·targetBlockIndex·-·1⏎·········` with `·?·targetBlockIndex·-·1` prettier/prettier ✖ 2 problems (1 error, 1 warning) 1 error, 0 warnings potentially fixable with the `--fix` option. ``` After fix: ``` > yarn run lint Using globally installed version of Yarn yarn run v1.5.1 $ eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ✨ Done in 8.50s. ``` (will be fixing the warning separately, that's been ongoing for a while). Pull Request resolved: facebookarchive/draft-js#1854 Reviewed By: elboman Differential Revision: D9636114 Pulled By: elboman fbshipit-source-id: 037c692554976b4626e27d3ebc0ccf95922bfb38
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Updating to 1.13.6 which is the version used internally in Facebook's codebase, so that there are no conflicts in how prettier dictates formatting. Right now, we're seeing an issue where 1.13.6 dictates different formatting for nested ternary operators & this broke the Travis CI in facebookarchive/draft-js@398f977...fcdb8fc#diff-4e6b8232e09a07f699eebad1949b3ba3L118 Looks like the earlier breakage due to prettier version upgrade reported in facebookarchive/draft-js#1562 is now not an issue with a much higher version :) **Test Plan** Before fix (breakage in Travis at https://travis-ci.org/facebook/draft-js/jobs/424170309): ``` $ eslint . /home/travis/build/facebook/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars /home/travis/build/facebook/draft-js/src/model/transaction/moveBlockInContentState.js 119:33 error Replace `⏎··········?·targetBlockIndex·-·1⏎·········` with `·?·targetBlockIndex·-·1` prettier/prettier ✖ 2 problems (1 error, 1 warning) 1 error, 0 warnings potentially fixable with the `--fix` option. ``` After fix: ``` > yarn run lint Using globally installed version of Yarn yarn run v1.5.1 $ eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ✨ Done in 8.50s. ``` (will be fixing the warning separately, that's been ongoing for a while). Pull Request resolved: facebookarchive/draft-js#1854 Reviewed By: elboman Differential Revision: D9636114 Pulled By: elboman fbshipit-source-id: 037c692554976b4626e27d3ebc0ccf95922bfb38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating to 1.13.6 which is the version used internally in Facebook's codebase, so that there are no conflicts in how prettier dictates formatting. Right now, we're seeing an issue where 1.13.6 dictates different formatting for nested ternary operators & this broke the Travis CI in 0cb80b7...fbc8a0c#diff-4e6b8232e09a07f699eebad1949b3ba3L118
Looks like the earlier breakage due to prettier version upgrade reported in #1562 is now not an issue with a much higher version :)
Test Plan
Before fix (breakage in Travis at https://travis-ci.org/facebook/draft-js/jobs/424170309):
After fix:
(will be fixing the warning separately, that's been ongoing for a while).