This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Remove unused var in BlockTree #1859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitermayer
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** This variable is unused & caused a lint warning. **Test Plan** Old (with warning): ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ``` New: ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . ``` Pull Request resolved: facebookarchive#1859 Differential Revision: D9762873 fbshipit-source-id: 42dab26c26164d08cda8fb2875a8fa4d6d3d9f1a
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** This variable is unused & caused a lint warning. **Test Plan** Old (with warning): ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ``` New: ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . ``` Pull Request resolved: facebookarchive/draft-js#1859 Differential Revision: D9762873 fbshipit-source-id: 42dab26c26164d08cda8fb2875a8fa4d6d3d9f1a
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** This variable is unused & caused a lint warning. **Test Plan** Old (with warning): ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . /Users/niveditc/draft-js/src/model/immutable/BlockTree.js 30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars ✖ 1 problem (0 errors, 1 warning) ``` New: ``` > npm run lint > draft-js@0.10.5 lint /Users/niveditc/draft-js > eslint . ``` Pull Request resolved: facebookarchive/draft-js#1859 Differential Revision: D9762873 fbshipit-source-id: 42dab26c26164d08cda8fb2875a8fa4d6d3d9f1a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This variable is unused & caused a lint warning.
Test Plan
Old (with warning):
New: