This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Support npm version 6.x #1866
Closed
Support npm version 6.x #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
yangshun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed
|
@niveditc shouldn't we also checkin a |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Now `nvm install 8` ends up installing npm 6.4.1 but our `package.json` doesn't support that npm version. This PR includes 6.x in the versions we support. More context: facebookarchive#1864 (comment) **Test Plan** CI tests. Pull Request resolved: facebookarchive#1866 Reviewed By: niveditc Differential Revision: D9789746 Pulled By: niveditc fbshipit-source-id: 8bdf8573c84d66bdce8281c4b2660df953399583
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Now `nvm install 8` ends up installing npm 6.4.1 but our `package.json` doesn't support that npm version. This PR includes 6.x in the versions we support. More context: facebookarchive/draft-js#1864 (comment) **Test Plan** CI tests. Pull Request resolved: facebookarchive/draft-js#1866 Reviewed By: niveditc Differential Revision: D9789746 Pulled By: niveditc fbshipit-source-id: 8bdf8573c84d66bdce8281c4b2660df953399583
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Now `nvm install 8` ends up installing npm 6.4.1 but our `package.json` doesn't support that npm version. This PR includes 6.x in the versions we support. More context: facebookarchive/draft-js#1864 (comment) **Test Plan** CI tests. Pull Request resolved: facebookarchive/draft-js#1866 Reviewed By: niveditc Differential Revision: D9789746 Pulled By: niveditc fbshipit-source-id: 8bdf8573c84d66bdce8281c4b2660df953399583
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now
nvm install 8ends up installing npm 6.4.1 but ourpackage.jsondoesn't support that npm version. This PR includes 6.x in the versions we support.More context: #1864 (comment)
Test Plan
CI tests.