This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
added favicon #1871
Closed
added favicon #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @saranshkataria, thanks for contributing this fix! It does address #1857 indeed. I'd rather use a black color for the icon, as white on transparent background is too faint. Or even a burgundy backdrop for the white icon. I'll chat with our designers to check which is the right approach! |
|
Okay, I see this design was accepted earlier on by @flarnie on #965, so I think it's okay to land and address forward. Thanks @saranshkataria! |
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: Fixed facebookarchive#1857 by adding a favicon. The color scheme of the icon needs to be thought about though since it is not visible when the tab is active because of the white color. On chrome:  Looks okay when the tab is inactive, but when it is active, the logo is not visible:  Pull Request resolved: facebookarchive#1871 Differential Revision: D9829164 fbshipit-source-id: 99c7f4d805b7da2713c3596992b39c125b63b221
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Fixed #1857 by adding a favicon. The color scheme of the icon needs to be thought about though since it is not visible when the tab is active because of the white color. On chrome:  Looks okay when the tab is inactive, but when it is active, the logo is not visible:  Pull Request resolved: facebookarchive/draft-js#1871 Differential Revision: D9829164 fbshipit-source-id: 99c7f4d805b7da2713c3596992b39c125b63b221
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Fixed #1857 by adding a favicon. The color scheme of the icon needs to be thought about though since it is not visible when the tab is active because of the white color. On chrome:  Looks okay when the tab is inactive, but when it is active, the logo is not visible:  Pull Request resolved: facebookarchive/draft-js#1871 Differential Revision: D9829164 fbshipit-source-id: 99c7f4d805b7da2713c3596992b39c125b63b221
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1857 by adding a favicon. The color scheme of the icon needs to be thought about though since it is not visible when the tab is active because of the white color.
On chrome:
Looks okay when the tab is inactive, but when it is active, the logo is not visible:
