This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Updates favicons and launcher icons with Draftjs logo #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…e#1872) Summary: **Summary** Updates icons and launcher icons to use the Draftjs logo on a maroon backdrop instead of the "D" letter. **Test Plan** * `yarn build && cd website && yarn start` * Verify the favicon is the new icon with the Draftjs logo <img width="170" alt="screen shot 2018-09-15 at 2 06 40 pm" src="https://user-images.githubusercontent.com/860099/45586618-1e9cf780-b8f2-11e8-8b7a-ebc20af5e5c4.png"> _**Note**: apparently, Docusaurus doesn't seem to use the apple and android launcher icons on this config. I'll try and look into that on a separate PR (will add support into Docusaurus itself if needed)_ Pull Request resolved: facebookarchive#1872 Differential Revision: D9846099 fbshipit-source-id: 347ae57270eebaeedadd324af9ca78a74421713c
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Updates icons and launcher icons to use the Draftjs logo on a maroon backdrop instead of the "D" letter. **Test Plan** * `yarn build && cd website && yarn start` * Verify the favicon is the new icon with the Draftjs logo <img width="170" alt="screen shot 2018-09-15 at 2 06 40 pm" src="https://user-images.githubusercontent.com/860099/45586618-1e9cf780-b8f2-11e8-8b7a-ebc20af5e5c4.png"> _**Note**: apparently, Docusaurus doesn't seem to use the apple and android launcher icons on this config. I'll try and look into that on a separate PR (will add support into Docusaurus itself if needed)_ Pull Request resolved: facebookarchive/draft-js#1872 Differential Revision: D9846099 fbshipit-source-id: 347ae57270eebaeedadd324af9ca78a74421713c
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Updates icons and launcher icons to use the Draftjs logo on a maroon backdrop instead of the "D" letter. **Test Plan** * `yarn build && cd website && yarn start` * Verify the favicon is the new icon with the Draftjs logo <img width="170" alt="screen shot 2018-09-15 at 2 06 40 pm" src="https://user-images.githubusercontent.com/860099/45586618-1e9cf780-b8f2-11e8-8b7a-ebc20af5e5c4.png"> _**Note**: apparently, Docusaurus doesn't seem to use the apple and android launcher icons on this config. I'll try and look into that on a separate PR (will add support into Docusaurus itself if needed)_ Pull Request resolved: facebookarchive/draft-js#1872 Differential Revision: D9846099 fbshipit-source-id: 347ae57270eebaeedadd324af9ca78a74421713c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates icons and launcher icons to use the Draftjs logo on a maroon backdrop instead of the "D" letter.
Test Plan
yarn build && cd website && yarn startNote: apparently, Docusaurus doesn't seem to use the apple and android launcher icons on this config. I'll try and look into that on a separate PR (will add support into Docusaurus itself if needed)