This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update documentation concerning immutable updates #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and when and how to use static methods
niveditc
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Adding some inline examples in the documentation around immutable updates for `EditorState`, `ContentState` and `SelectionState` based on the suggestions of facebookarchive#1445. Let me know if there's more areas in the documentation that could use similar examples or if some editing needs to be done to what I've added. **Test Plan** N/A, but I did view in online markdown editor and it looks ok Pull Request resolved: facebookarchive#1884 Differential Revision: D10188040 fbshipit-source-id: c91d935d3ffdb7aee9ccf826af68c91cf1596a0a
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Adding some inline examples in the documentation around immutable updates for `EditorState`, `ContentState` and `SelectionState` based on the suggestions of #1445. Let me know if there's more areas in the documentation that could use similar examples or if some editing needs to be done to what I've added. **Test Plan** N/A, but I did view in online markdown editor and it looks ok Pull Request resolved: facebookarchive/draft-js#1884 Differential Revision: D10188040 fbshipit-source-id: c91d935d3ffdb7aee9ccf826af68c91cf1596a0a
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Adding some inline examples in the documentation around immutable updates for `EditorState`, `ContentState` and `SelectionState` based on the suggestions of #1445. Let me know if there's more areas in the documentation that could use similar examples or if some editing needs to be done to what I've added. **Test Plan** N/A, but I did view in online markdown editor and it looks ok Pull Request resolved: facebookarchive/draft-js#1884 Differential Revision: D10188040 fbshipit-source-id: c91d935d3ffdb7aee9ccf826af68c91cf1596a0a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding some inline examples in the documentation around immutable updates for
EditorState,ContentStateandSelectionStatebased on the suggestions of #1445.Let me know if there's more areas in the documentation that could use similar examples or if some editing needs to be done to what I've added.
Test Plan
N/A, but I did view in online markdown editor and it looks ok