This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update docs to ensure kebab menu shows subheads #1885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Reference issue: facebookarchive#1873 The kebab menu for `docs` pages was empty on certain pages (it seems like a setting on the siteConfig.js that [controls whether this menu is shown or not](https://github.com/facebook/Docusaurus/blob/f2927a9fc458cc368ebae5474e55b755fe4120db/v1/lib/core/BlogPostLayout.js#L92). It doesn't seem like there's a way to override this on a per page basis with configuration). I modified the format of these pages to bring them more in line with similar `docs` pages. Also added headers to ensure all docs pages had a value in the kebab dropdown. Seemed easier than coding around it. **Test Plan** Verified the changes on `docs` pages locally Pull Request resolved: facebookarchive#1885 Differential Revision: D10187920 fbshipit-source-id: 9d130c62b1e79be1e87011d10d403d7773d6a412
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Reference issue: #1873 The kebab menu for `docs` pages was empty on certain pages (it seems like a setting on the siteConfig.js that [controls whether this menu is shown or not](https://github.com/facebook/Docusaurus/blob/f2927a9fc458cc368ebae5474e55b755fe4120db/v1/lib/core/BlogPostLayout.js#L92). It doesn't seem like there's a way to override this on a per page basis with configuration). I modified the format of these pages to bring them more in line with similar `docs` pages. Also added headers to ensure all docs pages had a value in the kebab dropdown. Seemed easier than coding around it. **Test Plan** Verified the changes on `docs` pages locally Pull Request resolved: facebookarchive/draft-js#1885 Differential Revision: D10187920 fbshipit-source-id: 9d130c62b1e79be1e87011d10d403d7773d6a412
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Reference issue: #1873 The kebab menu for `docs` pages was empty on certain pages (it seems like a setting on the siteConfig.js that [controls whether this menu is shown or not](https://github.com/facebook/Docusaurus/blob/f2927a9fc458cc368ebae5474e55b755fe4120db/v1/lib/core/BlogPostLayout.js#L92). It doesn't seem like there's a way to override this on a per page basis with configuration). I modified the format of these pages to bring them more in line with similar `docs` pages. Also added headers to ensure all docs pages had a value in the kebab dropdown. Seemed easier than coding around it. **Test Plan** Verified the changes on `docs` pages locally Pull Request resolved: facebookarchive/draft-js#1885 Differential Revision: D10187920 fbshipit-source-id: 9d130c62b1e79be1e87011d10d403d7773d6a412
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reference issue: #1873
The kebab menu for
docspages was empty on certain pages (it seems like a setting on the siteConfig.js that controls whether this menu is shown or not. It doesn't seem like there's a way to override this on a per page basis with configuration).I modified the format of these pages to bring them more in line with similar
docspages. Also added headers to ensure all docs pages had a value in the kebab dropdown. Seemed easier than coding around it.Test Plan
Verified the changes on
docspages locally