This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Improves editor overview example with min height and border #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @niveditc 😊 |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…archive#1887) Summary: **Summary** Improves editor overview example providing a code sample that sets the editor's min height and border, as well as focuses the editor when clicking the editor area. **Test Plan** Copy and paste example into CodeSandbox https://codesandbox.io/s/9y5162ryj4 Fixes facebookarchive#1880 Pull Request resolved: facebookarchive#1887 Differential Revision: D10200611 fbshipit-source-id: 5c261cf78d8d36e3255528b68d30d7b46e2908bf
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Improves editor overview example providing a code sample that sets the editor's min height and border, as well as focuses the editor when clicking the editor area. **Test Plan** Copy and paste example into CodeSandbox https://codesandbox.io/s/9y5162ryj4 Fixes #1880 Pull Request resolved: facebookarchive/draft-js#1887 Differential Revision: D10200611 fbshipit-source-id: 5c261cf78d8d36e3255528b68d30d7b46e2908bf
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Improves editor overview example providing a code sample that sets the editor's min height and border, as well as focuses the editor when clicking the editor area. **Test Plan** Copy and paste example into CodeSandbox https://codesandbox.io/s/9y5162ryj4 Fixes #1880 Pull Request resolved: facebookarchive/draft-js#1887 Differential Revision: D10200611 fbshipit-source-id: 5c261cf78d8d36e3255528b68d30d7b46e2908bf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves editor overview example providing a code sample that sets the editor's min height and border, as well as focuses the editor when clicking the editor area.
Test Plan
Copy and paste example into CodeSandbox
https://codesandbox.io/s/9y5162ryj4
Fixes #1880