This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Clarifies editor example, changes height to min-height #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…ve#1889) Summary: **Summary** Clarifies editor example, explaining how to use CSS selectors from the Draft.css stylesheet, changes `height` to `min-height` in example. **Test Plan** Tests on CodeSandbox: https://codesandbox.io/s/9y5162ryj4 Pull Request resolved: facebookarchive#1889 Differential Revision: D10207706 fbshipit-source-id: cf3a6eb659f486ec9a0d6e64018478b113c20922
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Clarifies editor example, explaining how to use CSS selectors from the Draft.css stylesheet, changes `height` to `min-height` in example. **Test Plan** Tests on CodeSandbox: https://codesandbox.io/s/9y5162ryj4 Pull Request resolved: facebookarchive/draft-js#1889 Differential Revision: D10207706 fbshipit-source-id: cf3a6eb659f486ec9a0d6e64018478b113c20922
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Clarifies editor example, explaining how to use CSS selectors from the Draft.css stylesheet, changes `height` to `min-height` in example. **Test Plan** Tests on CodeSandbox: https://codesandbox.io/s/9y5162ryj4 Pull Request resolved: facebookarchive/draft-js#1889 Differential Revision: D10207706 fbshipit-source-id: cf3a6eb659f486ec9a0d6e64018478b113c20922
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies editor example, explaining how to use CSS selectors from the Draft.css stylesheet, changes
heighttomin-heightin example.Test Plan
Tests on CodeSandbox: https://codesandbox.io/s/9y5162ryj4