This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Remove flow typing for DraftEntity mock #1891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
LGTM |
claudiopro
approved these changes
Oct 9, 2018
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Flow typing this file breaks Travis CI. See also discussion in facebookarchive#1890 **Test Plan** `yarn run flow` Pull Request resolved: facebookarchive#1891 Reviewed By: mjhu Differential Revision: D10250894 Pulled By: mjhu fbshipit-source-id: f6a3a54a8b2d2f2f589a035e42f1c743afd638b2
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Flow typing this file breaks Travis CI. See also discussion in #1890 **Test Plan** `yarn run flow` Pull Request resolved: facebookarchive/draft-js#1891 Reviewed By: mjhu Differential Revision: D10250894 Pulled By: mjhu fbshipit-source-id: f6a3a54a8b2d2f2f589a035e42f1c743afd638b2
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Flow typing this file breaks Travis CI. See also discussion in #1890 **Test Plan** `yarn run flow` Pull Request resolved: facebookarchive/draft-js#1891 Reviewed By: mjhu Differential Revision: D10250894 Pulled By: mjhu fbshipit-source-id: f6a3a54a8b2d2f2f589a035e42f1c743afd638b2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Flow typing this file breaks Travis CI. See also discussion in #1890
Test Plan
yarn run flow