Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Upgrades @babel/core, babel-preset-fbjs, and gulp-util #2028

Closed
wants to merge 4 commits into from

Conversation

claudiopro
Copy link
Contributor

@claudiopro claudiopro commented Mar 7, 2019

Summary

Addresses broken flow types extracted during the gulp build. Solves #2027

Upgrades the following dependencies:

  • babel-core@^6.8.0 -> @babel/core@^7.3.4
  • babel-preset-fbjs@^2.1.0 -> ^3.2.0
  • fbjs-scripts@^0.8.0 -> ^1.1.0
  • gulp-babel@^6.1.2 -> ^8.0.0
  • jest@^23.5.0 -> ^24.1.0

Test Plan

yarn
yarn test
yarn flow
yarn lint

Manual inspection of generated flow types under lib/

@claudiopro
Copy link
Contributor Author

And another one with babel-eslint related to eslint/eslint#9767, addressing by upgrading to babel-eslint@^8.1.1

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jdecked pushed a commit to twitter-forks/draft-js that referenced this pull request Oct 9, 2019
…ve#2028)

Summary:
**Summary**

Addresses broken flow types extracted during the gulp build. Solves facebookarchive#2027

Upgrades the following dependencies:

- babel-core@^6.8.0 -> babel/core@^7.3.4
- babel-preset-fbjs@^2.1.0 -> ^3.2.0
- fbjs-scripts@^0.8.0 -> ^1.1.0
- gulp-babel@^6.1.2 -> ^8.0.0
- jest@^23.5.0 -> ^24.1.0

**Test Plan**

yarn
yarn test
yarn flow

Manual inspection of generated flow types under `lib/`
Pull Request resolved: facebookarchive#2028

Reviewed By: mitermayer

Differential Revision: D14366317

Pulled By: mitermayer

fbshipit-source-id: 734c15717e94c3bc7f1a552496b67ce6a509da06
mmissey pushed a commit to mmissey/draft-js that referenced this pull request Mar 24, 2020
…ve#2028)

Summary:
**Summary**

Addresses broken flow types extracted during the gulp build. Solves facebookarchive#2027

Upgrades the following dependencies:

- babel-core@^6.8.0 -> babel/core@^7.3.4
- babel-preset-fbjs@^2.1.0 -> ^3.2.0
- fbjs-scripts@^0.8.0 -> ^1.1.0
- gulp-babel@^6.1.2 -> ^8.0.0
- jest@^23.5.0 -> ^24.1.0

**Test Plan**

yarn
yarn test
yarn flow

Manual inspection of generated flow types under `lib/`
Pull Request resolved: facebookarchive#2028

Reviewed By: mitermayer

Differential Revision: D14366317

Pulled By: mitermayer

fbshipit-source-id: 734c15717e94c3bc7f1a552496b67ce6a509da06
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**

Addresses broken flow types extracted during the gulp build. Solves #2027

Upgrades the following dependencies:

- babel-core@^6.8.0 -> babel/core@^7.3.4
- babel-preset-fbjs@^2.1.0 -> ^3.2.0
- fbjs-scripts@^0.8.0 -> ^1.1.0
- gulp-babel@^6.1.2 -> ^8.0.0
- jest@^23.5.0 -> ^24.1.0

**Test Plan**

yarn
yarn test
yarn flow

Manual inspection of generated flow types under `lib/`
Pull Request resolved: facebookarchive/draft-js#2028

Reviewed By: mitermayer

Differential Revision: D14366317

Pulled By: mitermayer

fbshipit-source-id: 734c15717e94c3bc7f1a552496b67ce6a509da06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants