This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Adding 'preserveSelectionOnBlur' prop #2128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this! Thanks for building it out, I'll import it (: |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mrkev ah great, thanks! So what's the process from here? It gets imported to your internal repo and then it'll make its way into the next release? |
|
@holloway yup— PRs get merged from the internal repo so we can keep the code we have inside and outside in sync, and we can test it against our internal codebases before merging. It'll be merged and available on master right away, and then be available with the release of 0.11.1 through NPM. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** This adds a `preserveSelectionOnBlur` prop as per facebookarchive#2123 **Test Plan** Tests were added for the two possible scenarios. I'm not sure how much to mock in this test because it is just testing a specific branch of code, so I've faked certain details like the rangeCount. What do you think mrkev claudiopro ? Pull Request resolved: facebookarchive#2128 Reviewed By: claudiopro Differential Revision: D16270879 Pulled By: mrkev fbshipit-source-id: 304af92c1211b8ff95741bff434b4fe3c4b6dd7d
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** This adds a `preserveSelectionOnBlur` prop as per facebookarchive#2123 **Test Plan** Tests were added for the two possible scenarios. I'm not sure how much to mock in this test because it is just testing a specific branch of code, so I've faked certain details like the rangeCount. What do you think mrkev claudiopro ? Pull Request resolved: facebookarchive#2128 Reviewed By: claudiopro Differential Revision: D16270879 Pulled By: mrkev fbshipit-source-id: 304af92c1211b8ff95741bff434b4fe3c4b6dd7d
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** This adds a `preserveSelectionOnBlur` prop as per facebookarchive/draft-js#2123 **Test Plan** Tests were added for the two possible scenarios. I'm not sure how much to mock in this test because it is just testing a specific branch of code, so I've faked certain details like the rangeCount. What do you think mrkev claudiopro ? Pull Request resolved: facebookarchive/draft-js#2128 Reviewed By: claudiopro Differential Revision: D16270879 Pulled By: mrkev fbshipit-source-id: 304af92c1211b8ff95741bff434b4fe3c4b6dd7d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a
preserveSelectionOnBlurprop as per #2123Test Plan
Tests were added for the two possible scenarios. I'm not sure how much to mock in this test because it is just testing a specific branch of code, so I've faked certain details like the rangeCount.
What do you think @mrkev @claudiopro ?