This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
updated hastext method to not account for zero space width chars #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: \u200B (zero space width chars) is put into the blockmap while inserting tokens. Therfore hastext returns true even when there is no text in the input. Updated hastext method to not account for zero space width chars. Reviewed By: claudiopro Differential Revision: D16868475 fbshipit-source-id: ebbc392dbddddedfd13fd6ed3d54d6ba476542ae
|
This pull request has been merged in 85aa3a3. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…ebookarchive#2163) Summary: Pull Request resolved: facebookarchive#2163 \u200B (zero space width chars) is put into the blockmap while inserting tokens. Therfore hastext returns true even when there is no text in the input. Updated hastext method to not account for zero space width chars. Reviewed By: claudiopro Differential Revision: D16868475 fbshipit-source-id: 1b0c9142c54e9c45d19fde516167ef34d02e719d
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
…ebookarchive#2163) Summary: Pull Request resolved: facebookarchive#2163 \u200B (zero space width chars) is put into the blockmap while inserting tokens. Therfore hastext returns true even when there is no text in the input. Updated hastext method to not account for zero space width chars. Reviewed By: claudiopro Differential Revision: D16868475 fbshipit-source-id: 1b0c9142c54e9c45d19fde516167ef34d02e719d
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Pull Request resolved: facebookarchive/draft-js#2163 \u200B (zero space width chars) is put into the blockmap while inserting tokens. Therfore hastext returns true even when there is no text in the input. Updated hastext method to not account for zero space width chars. Reviewed By: claudiopro Differential Revision: D16868475 fbshipit-source-id: 1b0c9142c54e9c45d19fde516167ef34d02e719d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: \u200B (zero space width chars) is put into the blockmap while inserting tokens. Therfore hastext returns true even when there is no text in the input. Updated hastext method to not account for zero space width chars.
Reviewed By: claudiopro
Differential Revision: D16868475