fixes #304, kudos to @andpor #2197
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Oh dang, this is awesome. Can we get rid of the |
Done. |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Should fix facebookarchive#304. Thanks andpor. **Summary** based on Andrzej's facebookarchive#1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: facebookarchive#2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
Summary: Should fix facebookarchive#304. Thanks andpor. **Summary** based on Andrzej's facebookarchive#1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: facebookarchive#2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
Summary: Should fix facebookarchive/draft-js#304. Thanks andpor. **Summary** based on Andrzej's facebookarchive/draft-js#1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: facebookarchive/draft-js#2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
Should fix #304.
Thanks @andpor.
Summary
based on Andrzej's #1223, issue has been there for an incredible 3.5 years. Let's fix this.