This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix React warnings #2221
Closed
Fix React warnings #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix instances of the React warning:
```
React.jsx: Spreading a key to JSX is a deprecated pattern. ' +
'Explicitly pass a key after spreading props in your JSX call. ' +
'E.g. <ComponentName {...props} key={key} />'
```
originating from https://github.com/facebook/react/blob/18d2e0c03e4496a824fdb7f89ea2a3d60c30d49a/packages/react/src/ReactElementValidator.js#L366-L373
This warning occurs when you spread a key with other props. There are probably more instances of this issue but these are the highest firing in our codebase.
steveluscher
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
@steveluscher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@steveluscher merged this pull request in 2595016. |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary:
**Summary**
Fix instances of the React warning:
```
React.jsx: Spreading a key to JSX is a deprecated pattern. ' +
'Explicitly pass a key after spreading props in your JSX call. ' +
'E.g. <ComponentName {...props} key={key} />'
```
originating from [React here](https://github.com/facebook/react/blob/18d2e0c03e4496a824fdb7f89ea2a3d60c30d49a/packages/react/src/ReactElementValidator.js#L366-L373)
This warning occurs when you spread a key with other props. There are probably more instances of this issue but these are the highest firing in our codebase.
**Test Plan**
`npm run lint && npm run test`
Pull Request resolved: facebookarchive#2221
Reviewed By: mitermayer
Differential Revision: D18038272
Pulled By: steveluscher
fbshipit-source-id: 736236601ace92ae1e8d127e10bb35e393fa14b7
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary:
**Summary**
Fix instances of the React warning:
```
React.jsx: Spreading a key to JSX is a deprecated pattern. ' +
'Explicitly pass a key after spreading props in your JSX call. ' +
'E.g. <ComponentName {...props} key={key} />'
```
originating from [React here](https://github.com/facebook/react/blob/18d2e0c03e4496a824fdb7f89ea2a3d60c30d49a/packages/react/src/ReactElementValidator.js#L366-L373)
This warning occurs when you spread a key with other props. There are probably more instances of this issue but these are the highest firing in our codebase.
**Test Plan**
`npm run lint && npm run test`
Pull Request resolved: facebookarchive#2221
Reviewed By: mitermayer
Differential Revision: D18038272
Pulled By: steveluscher
fbshipit-source-id: 736236601ace92ae1e8d127e10bb35e393fa14b7
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary:
**Summary**
Fix instances of the React warning:
```
React.jsx: Spreading a key to JSX is a deprecated pattern. ' +
'Explicitly pass a key after spreading props in your JSX call. ' +
'E.g. <ComponentName {...props} key={key} />'
```
originating from [React here](https://github.com/facebook/react/blob/18d2e0c03e4496a824fdb7f89ea2a3d60c30d49a/packages/react/src/ReactElementValidator.js#L366-L373)
This warning occurs when you spread a key with other props. There are probably more instances of this issue but these are the highest firing in our codebase.
**Test Plan**
`npm run lint && npm run test`
Pull Request resolved: facebookarchive/draft-js#2221
Reviewed By: mitermayer
Differential Revision: D18038272
Pulled By: steveluscher
fbshipit-source-id: 736236601ace92ae1e8d127e10bb35e393fa14b7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix instances of the React warning:
originating from React here
This warning occurs when you spread a key with other props. There are probably more instances of this issue but these are the highest firing in our codebase.
Test Plan
npm run lint && npm run test