Implement click listener for editor wrapper #2230
Conversation
As I understand the `onClick` listener on the wrapper `div` element is suppose to replicate native `textarea/input` behavior. But the actual value of `onClick` property was `undefined` instead of a real method `domEditor`s method.
|
Hi necinc! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
maximalism2
changed the title
|
lgtm! I'll try to get this merged soon. |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** As I understand the `onClick` listener on the wrapper `div` element is suppose to replicate native `textarea/input` behavior. But the actual value of `onClick` property was `undefined` and thus needed to be implemented **Test Plan** It's an example file, no test plan is required. Pull Request resolved: facebookarchive#2230 Differential Revision: D18247675 Pulled By: mrkev fbshipit-source-id: 88e7160776f66daf1033351e4c5f2f4cfb5d40f1
Summary: **Summary** As I understand the `onClick` listener on the wrapper `div` element is suppose to replicate native `textarea/input` behavior. But the actual value of `onClick` property was `undefined` and thus needed to be implemented **Test Plan** It's an example file, no test plan is required. Pull Request resolved: facebookarchive#2230 Differential Revision: D18247675 Pulled By: mrkev fbshipit-source-id: 88e7160776f66daf1033351e4c5f2f4cfb5d40f1
Summary: **Summary** As I understand the `onClick` listener on the wrapper `div` element is suppose to replicate native `textarea/input` behavior. But the actual value of `onClick` property was `undefined` and thus needed to be implemented **Test Plan** It's an example file, no test plan is required. Pull Request resolved: facebookarchive/draft-js#2230 Differential Revision: D18247675 Pulled By: mrkev fbshipit-source-id: 88e7160776f66daf1033351e4c5f2f4cfb5d40f1
Summary
As I understand the
onClicklistener on the wrapperdivelement is suppose to replicate nativetextarea/inputbehavior. But the actual value ofonClickproperty wasundefinedand thus needed to be implementedTest Plan
It's an example file, no test plan is required.