This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Upgrade to Docusaurus 2 #2268
Closed
Upgrade to Docusaurus 2 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Dec 1, 2019
| @@ -0,0 +1,100 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file already exists in the D1 version, just renamed.
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| ReactDOM.render( |
There was a problem hiding this comment.
This is transferred into a separate component.
claudiopro
added
dependencies
There was a problem hiding this comment.
@yangshun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This is looking good - I'd prefer to leave the theme color the same as it affects branding (e.g. Twitter account, sticker designs etc.) and would require broader coordination. The project is indeed screaming for better branding and would love to plan something in H1. Let's keep the impact of dark mode on theme colors in a separate conversation for now. |
|
I think it's okay to leave the current theme color for dark mode for the time being, but I like that you're trying to refresh the look of the website 😃 let's chat about the dark theme for the editor itself on a separate issue.
|
claudiopro
suggested changes
Dec 3, 2019
There was a problem hiding this comment.
@yangshun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yangshun
commented
Dec 4, 2019
| @@ -49,7 +49,7 @@ script: | |||
| git config --global user.name "Travis CI" | |||
| git config --global user.email "travis@reactjs.org" | |||
| echo "machine github.com login reactjs-bot password $GITHUB_TOKEN" > ~/.netrc | |||
| cd website && yarn install && GIT_USER=reactjs-bot npm run publish-gh-pages | |||
| cd website && yarn install && GIT_USER=reactjs-bot USE_SSH=true yarn deploy | |||
There was a problem hiding this comment.
This is the new deploy command in Docusaurus v2
| @@ -74,7 +74,7 @@ supplied text. | |||
| </li> | |||
| <li> | |||
| <a href="#getcharacterlist"> | |||
| <pre>getCharacterList(): List<CharacterMetadata></pre> | |||
| <pre>getCharacterList(): List<CharacterMetadata></pre> | |||
There was a problem hiding this comment.
Unfortunately we use MDX (JSX in Markdown) now so it thinks <CharacterMetadata> is a React component and I have to change it to use the character entity references.
|
The dark mode for the editor needs more work - the editor text is still the same shade of gray and can hardly be seen, hence I disabled it. Unless you think it's not an issue at all then I shall enable it :D |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** Fixes facebookarchive#2261. This should be merged after facebookarchive#2267 (how I wish there were stacked diffs on GitHub) Migrate the website to Docusaurus 2 which provides the following benefits specific to Draft.js: - Consistency with the other FB Docusaurus websites - Easy way to import Draft.js (bundle via webpack, no more ugly client-side script tags) - Nicer CSS framework - Dark mode (disabled for now until I sort out the dark mode styling for the editor) Changes made: - I also changed the theme color of Draft.js to be lighter brown so that the contrast is better in general (much better on dark mode). Let me know if this is not ok. **Test Plan** <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 32 PM" src="https://user-images.githubusercontent.com/1315101/69909874-bc28fd80-13b6-11ea-90bb-c6b44a1186a5.png"> <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 39 PM" src="https://user-images.githubusercontent.com/1315101/69909875-bcc19400-13b6-11ea-9eda-c6eabfc4fde4.png"> Try it out here - https://build-swart-eight.now.sh Pull Request resolved: facebookarchive#2268 Reviewed By: mrkev Differential Revision: D18758642 Pulled By: yangshun fbshipit-source-id: 169087f716ef2792dade75388b86debbaf34ac44
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** Fixes facebookarchive#2261. This should be merged after facebookarchive#2267 (how I wish there were stacked diffs on GitHub) Migrate the website to Docusaurus 2 which provides the following benefits specific to Draft.js: - Consistency with the other FB Docusaurus websites - Easy way to import Draft.js (bundle via webpack, no more ugly client-side script tags) - Nicer CSS framework - Dark mode (disabled for now until I sort out the dark mode styling for the editor) Changes made: - I also changed the theme color of Draft.js to be lighter brown so that the contrast is better in general (much better on dark mode). Let me know if this is not ok. **Test Plan** <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 32 PM" src="https://user-images.githubusercontent.com/1315101/69909874-bc28fd80-13b6-11ea-90bb-c6b44a1186a5.png"> <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 39 PM" src="https://user-images.githubusercontent.com/1315101/69909875-bcc19400-13b6-11ea-9eda-c6eabfc4fde4.png"> Try it out here - https://build-swart-eight.now.sh Pull Request resolved: facebookarchive#2268 Reviewed By: mrkev Differential Revision: D18758642 Pulled By: yangshun fbshipit-source-id: 169087f716ef2792dade75388b86debbaf34ac44
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Fixes facebookarchive/draft-js#2261. This should be merged after facebookarchive/draft-js#2267 (how I wish there were stacked diffs on GitHub) Migrate the website to Docusaurus 2 which provides the following benefits specific to Draft.js: - Consistency with the other FB Docusaurus websites - Easy way to import Draft.js (bundle via webpack, no more ugly client-side script tags) - Nicer CSS framework - Dark mode (disabled for now until I sort out the dark mode styling for the editor) Changes made: - I also changed the theme color of Draft.js to be lighter brown so that the contrast is better in general (much better on dark mode). Let me know if this is not ok. **Test Plan** <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 32 PM" src="https://user-images.githubusercontent.com/1315101/69909874-bc28fd80-13b6-11ea-90bb-c6b44a1186a5.png"> <img width="1552" alt="Screen Shot 2019-11-30 at 9 16 39 PM" src="https://user-images.githubusercontent.com/1315101/69909875-bcc19400-13b6-11ea-9eda-c6eabfc4fde4.png"> Try it out here - https://build-swart-eight.now.sh Pull Request resolved: facebookarchive/draft-js#2268 Reviewed By: mrkev Differential Revision: D18758642 Pulled By: yangshun fbshipit-source-id: 169087f716ef2792dade75388b86debbaf34ac44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2261. This should be merged after #2267 (how I wish there were stacked diffs on GitHub)
Migrate the website to Docusaurus 2 which provides the following benefits specific to Draft.js:
Changes made:
Test Plan
Try it out here - https://build-swart-eight.now.sh