This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add rules to .flowconfig for flow strict rules #2288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally at facebook, we use `@flow strict` to define certain rules that make our codebase more reliable. I just noticed the .flowconfig for this repo doesn't include rules for `@flow strict`. We do have files in the repo annotated with strict flow, so lets configure it to get the benefits. Unfortunatley, there's 3 rules we have enabled internally which we can't use in the repo as it exists today. I put the necessary info as a comment on the .flowconfig itself. npm run flow -> no errors.
|
This is great! It will eliminate a lot of inconsistencies between OSS repo and www 👍 This will also cover us with |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: Internally at facebook, we use `flow strict` to define certain rules that make our codebase more reliable. I just noticed the .flowconfig for this repo doesn't include rules for `flow strict`. We do have files in the repo annotated with strict flow, so lets configure it to get the benefits. Unfortunatley, there's 3 rules we have enabled internally which we can't use in the repo as it exists today. I put the necessary info as a comment on the .flowconfig itself. npm run flow -> no errors. Pull Request resolved: facebookarchive#2288 Differential Revision: D19265177 Pulled By: mrkev fbshipit-source-id: 0eca719027d62c2681cd09be03385ba53a27c2e3
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: Internally at facebook, we use `flow strict` to define certain rules that make our codebase more reliable. I just noticed the .flowconfig for this repo doesn't include rules for `flow strict`. We do have files in the repo annotated with strict flow, so lets configure it to get the benefits. Unfortunatley, there's 3 rules we have enabled internally which we can't use in the repo as it exists today. I put the necessary info as a comment on the .flowconfig itself. npm run flow -> no errors. Pull Request resolved: facebookarchive#2288 Differential Revision: D19265177 Pulled By: mrkev fbshipit-source-id: 0eca719027d62c2681cd09be03385ba53a27c2e3
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Internally at facebook, we use `flow strict` to define certain rules that make our codebase more reliable. I just noticed the .flowconfig for this repo doesn't include rules for `flow strict`. We do have files in the repo annotated with strict flow, so lets configure it to get the benefits. Unfortunatley, there's 3 rules we have enabled internally which we can't use in the repo as it exists today. I put the necessary info as a comment on the .flowconfig itself. npm run flow -> no errors. Pull Request resolved: facebookarchive/draft-js#2288 Differential Revision: D19265177 Pulled By: mrkev fbshipit-source-id: 0eca719027d62c2681cd09be03385ba53a27c2e3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally at facebook, we use
@flow strictto define certain rules that make our codebase more reliable. I just noticed the .flowconfig for this repo doesn't include rules for@flow strict. We do have files in the repo annotated with strict flow, so lets configure it to get the benefits.Unfortunatley, there's 3 rules we have enabled internally which we can't use in the repo as it exists today. I put the necessary info as a comment on the .flowconfig itself.
npm run flow -> no errors.