This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix Uncaught TypeError: Cannot read property 'nodeType' of null at ed… #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Mar 24, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 24, 2020
Summary: #2330 broke the build (_sigh_). CI was broken for a while, so it wasn't immediately obvious too. Internally, we have supported optional chaining for a while, so importing to Phabricator didn't surface the error either. We need a babel transform for optional chaining. ## Test plan. Build draft. Build succeeds. Open one of the examples. It works. Pull Request resolved: #2363 Reviewed By: creedarky Differential Revision: D20632298 Pulled By: mrkev fbshipit-source-id: 7a591c376330ee31bac5546a765920833b6bac00
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 31, 2020
Summary: **Summary** Turns out the optional chaining PR (#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types. **Test Plan** `flow .` Pull Request resolved: #2369 Reviewed By: claudiopro Differential Revision: D20680346 Pulled By: mrkev fbshipit-source-id: c30392a4e8084521c7e66f303fbc5f4832866e98
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
facebookarchive#2330) Summary: facebookarchive#2204 Pull Request resolved: facebookarchive#2330 Reviewed By: claudiopro Differential Revision: D20582792 Pulled By: mrkev fbshipit-source-id: d96beaa1617ef82ba5663637f5daad254d9b17f7
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: facebookarchive#2330 broke the build (_sigh_). CI was broken for a while, so it wasn't immediately obvious too. Internally, we have supported optional chaining for a while, so importing to Phabricator didn't surface the error either. We need a babel transform for optional chaining. ## Test plan. Build draft. Build succeeds. Open one of the examples. It works. Pull Request resolved: facebookarchive#2363 Reviewed By: creedarky Differential Revision: D20632298 Pulled By: mrkev fbshipit-source-id: 7a591c376330ee31bac5546a765920833b6bac00
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** Turns out the optional chaining PR (facebookarchive#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types. **Test Plan** `flow .` Pull Request resolved: facebookarchive#2369 Reviewed By: claudiopro Differential Revision: D20680346 Pulled By: mrkev fbshipit-source-id: c30392a4e8084521c7e66f303fbc5f4832866e98
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…… (#2330) Summary: facebookarchive/draft-js#2204 Pull Request resolved: facebookarchive/draft-js#2330 Reviewed By: claudiopro Differential Revision: D20582792 Pulled By: mrkev fbshipit-source-id: d96beaa1617ef82ba5663637f5daad254d9b17f7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2204