Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Don't SSR example editor on website. #2356

Closed
wants to merge 1 commit into from
Closed

Don't SSR example editor on website. #2356

wants to merge 1 commit into from

Conversation

mrkev
Copy link
Contributor

@mrkev mrkev commented Mar 19, 2020

There's suspicion the example editor fails in prod because of an SSR error, so lets not SSR-it. Also upgrades draft to the latest version on npm.

Test Plan

yarn start, played around with the editor.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@mrkev merged this pull request in 9191a3f.

@yangshun
Copy link
Contributor

Good one, thanks!

mmissey pushed a commit to mmissey/draft-js that referenced this pull request Mar 24, 2020
Summary:
There's suspicion the example editor fails in prod because of an SSR error, so lets not SSR-it. Also upgrades draft to the latest version on npm.
Pull Request resolved: facebookarchive#2356

Test Plan: `yarn start`, played around with the editor.

Reviewed By: claudiopro

Differential Revision: D20532633

Pulled By: mrkev

fbshipit-source-id: 934427d2e1a35232ee9f12632e539817a1f2eaa8
vilemj-Viclick pushed a commit to kontent-ai/draft-js that referenced this pull request Jul 16, 2020
Summary:
There's suspicion the example editor fails in prod because of an SSR error, so lets not SSR-it. Also upgrades draft to the latest version on npm.
Pull Request resolved: facebookarchive#2356

Test Plan: `yarn start`, played around with the editor.

Reviewed By: claudiopro

Differential Revision: D20532633

Pulled By: mrkev

fbshipit-source-id: 934427d2e1a35232ee9f12632e539817a1f2eaa8
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
There's suspicion the example editor fails in prod because of an SSR error, so lets not SSR-it. Also upgrades draft to the latest version on npm.
Pull Request resolved: facebookarchive/draft-js#2356

Test Plan: `yarn start`, played around with the editor.

Reviewed By: claudiopro

Differential Revision: D20532633

Pulled By: mrkev

fbshipit-source-id: 934427d2e1a35232ee9f12632e539817a1f2eaa8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants